Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Item stack clicking interaction events #1187

Open
wants to merge 21 commits into
base: 1.17
Choose a base branch
from

Conversation

BoogieMonster1O1
Copy link

This adds two interaction events that fire before ItemStack#onClicked and ItemStack#onStackClicked. Both are cancellable.

here's the testmod (a miniature fluid api 😄) - https://i.imgur.com/2APkSj3.mp4

@oliviathevampire
Copy link

Seems like you have some unused imports which makes the checks fail

@Prospector
Copy link
Contributor

The API looks fine to me, my only suggestion would be to maybe simplify the test mod? It seems a bit complicated and is nearly half of the PR. It's also not entirely clear to me from your video how it is supposed to be working. Perhaps some more obvious and simplified tests would be better, and more helpful to future maintainers of this code.

@i509VCB i509VCB added enhancement New feature or request reviews needed This PR needs more reviews labels Dec 6, 2020
@i509VCB i509VCB added the priority:low Low priority PRs that don't immediately need to be resolved label Jan 19, 2021
@maityyy
Copy link
Contributor

maityyy commented Dec 17, 2021

Any updates?

@kanpov
Copy link

kanpov commented Jan 3, 2022

Any updates?

another abandoned fabric pr in the bag

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request priority:low Low priority PRs that don't immediately need to be resolved reviews needed This PR needs more reviews
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants