-
Notifications
You must be signed in to change notification settings - Fork 433
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Item stack clicking interaction events #1187
base: 1.17
Are you sure you want to change the base?
Item stack clicking interaction events #1187
Conversation
Seems like you have some unused imports which makes the checks fail |
The API looks fine to me, my only suggestion would be to maybe simplify the test mod? It seems a bit complicated and is nearly half of the PR. It's also not entirely clear to me from your video how it is supposed to be working. Perhaps some more obvious and simplified tests would be better, and more helpful to future maintainers of this code. |
Any updates? |
another abandoned fabric pr in the bag |
This adds two interaction events that fire before
ItemStack#onClicked
andItemStack#onStackClicked
. Both are cancellable.here's the testmod (a miniature fluid api 😄) - https://i.imgur.com/2APkSj3.mp4