Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sort extra manifest attributes #958

Merged
merged 1 commit into from
Oct 15, 2023
Merged

Sort extra manifest attributes #958

merged 1 commit into from
Oct 15, 2023

Conversation

haykam821
Copy link
Contributor

@haykam821 haykam821 commented Oct 10, 2023 •
edited
Loading

This pull request fixes an issue where extra manifest attributes did not have a defined order by sorting them by their keys.

Previously, MANIFEST.MF could contain either of the following orders, inhibiting the reproducibility of builds:

Fabric-Loom-Split-Environment: true
Fabric-Loom-Client-Only-Entries: 

Fabric-Loom-Client-Only-Entries: 
Fabric-Loom-Split-Environment: true

@haykam821 haykam821 force-pushed the sort-extra-attributes branch from 1cb66de to 9efc729 Compare October 10, 2023 17:01
@modmuss50 modmuss50 changed the base branch from dev/1.4 to tmp/1.4 October 15, 2023 09:45
@modmuss50 modmuss50 merged commit e29d66f into FabricMC:tmp/1.4 Oct 15, 2023
74 checks passed
@haykam821 haykam821 deleted the sort-extra-attributes branch October 15, 2023 14:54
modmuss50 pushed a commit that referenced this pull request Oct 16, 2023
@haykam821 @modmuss50
Sort extra manifest attributes (#958)
78a903d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@modmuss50 modmuss50 modmuss50 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@haykam821 @modmuss50