Update scala version, and buildscript #23
Conversation
LICENSE
Outdated
There was a problem hiding this comment.
I don't think changing the license is acceptable.
There was a problem hiding this comment.
oh idk i just changed it so it matched with the newer fabric stuff
There was a problem hiding this comment.
Yeah, dont change the license like this, if there is a reason to there is a whole process we would need to go through.
build.gradle
Outdated
| // Scala Dependencies | ||
| implementation "org.scala-lang:scala3-library_3:${project.scala_version}" | ||
| implementation "org.scala-lang:scala-reflect:${project.scala_reflect_version}" | ||
| implementation "org.scala-lang.modules:scala-xml_3:${project.scala_xml_version}"// might be unnecessary but wtv |
There was a problem hiding this comment.
Is this needed or not? I dont see why it would be, why also add scala-reflect?
There was a problem hiding this comment.
adding scala reflect can add more complex coding practice when using scala. and the xml idk why i added that i think it was just late at night so i wasnt thinking.
There was a problem hiding this comment.
Ok, thanks I have removed them. Its much easier to add them later if needed.
| } | ||
| } | ||
|
|
||
| curseforge { |
There was a problem hiding this comment.
oh i didnt know fabric was on curseforge anymore
There was a problem hiding this comment.
Its fine, I would have also removed this plugin as I have my own. Ill sort this out after merging.
| // Scala Dependencies | ||
| implementation "org.scala-lang:scala3-library_3:${project.scala_version}" |
There was a problem hiding this comment.
Does it seems right? I don't think this is the correct nested-jar.
After I testing about it, I can't find any bundled jar in fabric-language-scala.
Maybe correcting it into
modApi(include("org.scala-lang:scala3-library_3:${project.scala_version}"))
like fabric-language-kotlin will be ok?
|
Wait, I found a problem, it seems that loom is not recognizing my Scala source path correctly?
loom {
splitEnvironmentSourceSets()
mods {
"kmmo" {
sourceSet sourceSets.main
sourceSet sourceSets.client
}
}
} |
No description provided.