-
Notifications
You must be signed in to change notification settings - Fork 120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to 1.21.4: "Creating Your First Item" #250
Closed
+20
−0
Closed
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -100,6 +100,15 @@ | |
|
||
@[code](@/reference/latest/src/main/resources/assets/fabric-docs-reference/models/item/suspicious_substance.json) | ||
|
||
But we're still missing a thing: the item still doesn't load? | ||
|
||
### Adding an Item Description {#adding-an-item-description} | ||
|
||
Since 1.21.4, Minecraft won't try to guess your item model's location anymore, and so, we need to provide an item description. | ||
|
||
Create the item description JSON in the `assets/<mod id here>/items`, with the same name as the item; `suspicious_substance.json`. | ||
@[code](@/reference/latest/src/main/resources/assets/fabric-docs-reference/items/suspicious_substance.json) | ||
|
||
### Breaking Down the Model JSON {#breaking-down-the-model-json} | ||
|
||
- `parent`: This is the parent model that this model will inherit from. In this case, it's the `item/generated` model. | ||
|
@@ -109,6 +118,11 @@ | |
|
||
There are alternatives, such as `item/handheld` which is used for items that are held in the player's hand, such as tools. | ||
|
||
### Breaking Down the Item Description JSON {#breaking-down-the-item-description-json} | ||
Check failure on line 121 in develop/items/first-item.md GitHub Actions / markdownlintHeadings should be surrounded by blank lines
|
||
- `model`: This is the property that contains the reference to our model. | ||
Check failure on line 122 in develop/items/first-item.md GitHub Actions / markdownlintLists should be surrounded by blank lines
|
||
- `type`: This is the type of our model. For most items, this should be `minecraft:model` | ||
- `model`: This is the model's identifier. It should have this form: `<mod id here>:item/<item name here>` | ||
|
||
Your item should now look like this in-game: | ||
|
||
![Item with correct model](/assets/develop/items/first_item_2.png) | ||
|
6 changes: 6 additions & 0 deletions
6
...ce/1.20.4/src/main/resources/assets/fabric-docs-reference/items/suspicious_substance.json
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,6 @@ | ||
{ | ||
"model": { | ||
"type": "minecraft:model", | ||
"model": "mod_id:item/suspicious_substance" | ||
} | ||
} |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This has been created in the wrong folder (
1.20.4
instead oflatest
), we should also be data generating this instead of just placing raw JSON files.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oops