Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to 1.21.4 #242

Merged
merged 12 commits into from
Jan 15, 2025
Merged

Update to 1.21.4 #242

merged 12 commits into from
Jan 15, 2025

Conversation

modmuss50
Copy link
Member

@modmuss50 modmuss50 commented Dec 30, 2024

Supersedes #206, #210, #226

Fixes #216, #231, #233

Depends on #244


TODO

Existing Large Changes

These changes will need to be taken into consideration when updating their pages.

  • Advancement criteria in data generator now use registry wrappers.
  • Renderlayers must be passed to drawTexture to draw textures on screens.
  • Shaders moved from GameRenderer to ShaderProgramKeys
  • Block settings now require registry keys.
  • Item settings now require registry keys.
  • Food components split into 2, consumable component for status effect relating stuff, food component for anything related to saturation etc.
  • Entire custom armor process has been redone... again...
  • Tool materials have changed again.

Copy link

netlify bot commented Dec 30, 2024

Deploy Preview for nimble-elf-d9d491 failed.

Name Link
🔨 Latest commit a5f97d0
🔍 Latest deploy log https://app.netlify.com/sites/nimble-elf-d9d491/deploys/6787caccbde7f4000883a864

@its-miroma its-miroma mentioned this pull request Dec 30, 2024
@its-miroma its-miroma added new-version Related to a newer version of Minecraft stage:expansion This should be expanded labels Dec 30, 2024
@its-miroma its-miroma changed the title 1.21.4 port Update to 1.21.4 Dec 30, 2024
@IMB11 IMB11 mentioned this pull request Dec 30, 2024
4 tasks
@IMB11 IMB11 added this to the Update to 1.21.4 milestone Dec 30, 2024
@IMB11
Copy link
Member

IMB11 commented Jan 9, 2025

TODO: Before merging, make sure to merge the crowdin PR from main branch and copy it into versioned/1.21/translations ... folder

@IMB11 IMB11 marked this pull request as ready for review January 15, 2025 12:03
@IMB11 IMB11 requested review from a team as code owners January 15, 2025 12:03
@IMB11 IMB11 added stage:ready This is ready to be merged and removed stage:expansion This should be expanded labels Jan 15, 2025
IMB11
IMB11 previously approved these changes Jan 15, 2025
@IMB11 IMB11 dismissed their stale review January 15, 2025 14:19

Waiting

Copy link
Member

@its-miroma its-miroma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we must fix links in versions/1.21/translated

@IMB11
Copy link
Member

IMB11 commented Jan 15, 2025

LGTM

@IMB11 IMB11 requested a review from its-miroma January 15, 2025 14:49
@modmuss50 modmuss50 merged commit caf30e4 into main Jan 15, 2025
5 of 9 checks passed
@modmuss50 modmuss50 deleted the port/1.21.4 branch January 15, 2025 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new-version Related to a newer version of Minecraft stage:ready This is ready to be merged
Projects
None yet
4 participants