Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Fix interface injector visibility checks. #156

Merged
merged 1 commit into from
Sep 3, 2024
Merged

Fix: Fix interface injector visibility checks. #156

merged 1 commit into from
Sep 3, 2024

Commits on Aug 30, 2024

  1. Fix: Fix interface injector visibility checks. 

    `InjectionInfo.parse` can be very expensive and in the case of some MixinExtras features is not pure.
The correct approach would be to use `InjectionInfo.getInjectorAnnotation`, but the override is no longer needed anyway since we only support Java 8+ so Mixin will already make injector methods private and synthetic.
Except, Mixin does it based on the current `COMPATIBILITY_LEVEL`, which is wrong, because we could be on JAVA_17 and yet a class compiled with JAVA_8 had no choice but to use public methods.
The original implementation was also incomplete because it forgot about default methods.
    @LlamaLad7
    LlamaLad7 committed Aug 30, 2024
    Configuration menu
    Copy the full SHA
    56902db View commit details
    Browse the repository at this point in the history