Fix/modifyarg(s) after redirect #128
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LlamaLad7
force-pushed
the
fix/modifyarg(s)-after-redirect
branch
from
b90d7a7
to
b738ed2
Compare
LlamaLad7
force-pushed
the
fix/modifyarg(s)-after-redirect
branch
from
b738ed2
to
9f55488
Compare
modmuss50
approved these changes
Mar 3, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently
@ModifyArg(s)doesn't check whether the targeted call has been redirected and as a result there are errors with mismatching indices / invalid implicit discriminators.Tested with AOF7, doesn't break anything.
Supersedes #114
Fixes SpongePowered#544