Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Finalize Build #9

Open
wants to merge 33 commits into
base: feature/node-16
Choose a base branch
from
Open

Finalize Build #9

wants to merge 33 commits into from

Conversation

martindale
Copy link
Member

@martindale martindale commented Jun 9, 2022

Fully working build (with Rollup)

Dependency Checks

  • @fabric/core#feature/node-16
  • @fabric/http#feature/node-16
  • @fabric/react#feature/node-16

@martindale martindale marked this pull request as ready for review June 9, 2022 03:32
@martindale
Copy link
Member Author

@anandsuresh early preview here; this branch of this repo is what a full deploy of Portal will contain — we're paring down the list of dependencies that are needed above and beyond Fabric. Might be good to take a glance at what your nixify script reports here, then we can file bugs against upstream (@fabric/core, @fabric/http, @fabric/react).

Aiming to merge into feature/node-16 and soon master...

@martindale martindale requested review from melnx and victorwu June 9, 2022 03:36
@martindale
Copy link
Member Author

@melnx @victorwu fresh install works here, but still missing import of FabricBridge from @fabric/react — use npm run dev and check http://localhost:3000

NPM install looks to take < 3 minutes, but please report your results!

@martindale martindale self-assigned this Jun 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants