Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

readded asset manifests #50

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

perriDplatypus
Copy link

Reactivated assets/manifest.json (ISSUE #47)

Copy link

sweep-ai bot commented Dec 27, 2023

Apply Sweep Rules to your PR?

  • Apply: All new business logic should have corresponding unit tests.
  • Apply: Refactor large functions to be more modular.
  • Apply: Add docstrings to all functions and file headers.

@martindale
Copy link
Member

The manifest should be built with the latest information from Compiler, which provides the webpack configuration — ideally, the build file includes some hash which changes on every build, which regenerates manifest.json

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants