Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Carry experimental cortical_profile_sampler and helpers to siibra subpackages #619

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

AhmetNSimsek
Copy link
Collaborator

@AhmetNSimsek AhmetNSimsek commented Nov 14, 2024

Move cortical profile sampler from experimental subpackage
(work in progress)

Copy link

codecov bot commented Nov 14, 2024

Codecov Report

Attention: Patch coverage is 38.75000% with 49 lines in your changes missing coverage. Please review.

Project coverage is 45.94%. Comparing base (dc63457) to head (b0cb65a).
Report is 10 commits behind head on main.

Files with missing lines Patch % Lines
siibra/volumes/volume.py 17.64% 28 Missing ⚠️
siibra/locations/pointset.py 18.75% 13 Missing ⚠️
siibra/livequeries/cortical_profile_sampler.py 63.63% 4 Missing ⚠️
siibra/locations/plane.py 63.63% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #619      +/-   ##
==========================================
- Coverage   46.00%   45.94%   -0.07%     
==========================================
  Files          75       72       -3     
  Lines        7232     7235       +3     
==========================================
- Hits         3327     3324       -3     
- Misses       3905     3911       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@AhmetNSimsek AhmetNSimsek added enhancement New feature or request maintenance Not a bug or breaking issue. Code maintenance related. labels Nov 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request maintenance Not a bug or breaking issue. Code maintenance related.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants