Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🚀 mommy is now way faster~ #106

Merged
merged 3 commits into from
Feb 21, 2024
Merged

🚀 mommy is now way faster~ #106

merged 3 commits into from
Feb 21, 2024

Conversation

FWDekker
Copy link
Owner

@FWDekker FWDekker commented Feb 20, 2024

i created a cool performance branch a while ago but i thought it became too difficult at some point so i quit. now i tried again, and the unit tests now run in ~1 second instead of ~4 seconds. all i had to do was summon evil magics to avoid as many subshells as possible!

additionally, all echos are replaced with printfs (for compatibility) and a bunch of test/[s had to be rewritten because openbsd is being silly and thinks [ -z "$x" ] is a comparison if x=<. i also renamed most variables so they can be nested and can call each other without overwriting each other's variables~

ps: i bet this won't work on openbsd, i'll have to fix that... (edit: that has been fixed)

@FWDekker FWDekker added the code quality Code changes without behavior changes label Feb 20, 2024
@FWDekker FWDekker self-assigned this Feb 20, 2024
@FWDekker FWDekker merged commit 67529af into main Feb 21, 2024
18 checks passed
@FWDekker FWDekker deleted the performance-2 branch February 21, 2024 07:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code quality Code changes without behavior changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant