Make ngx_postgres possible to build as dynamic module #54
Conversation
| ngx_feature_test="(void) PQescapeLiteral(NULL, NULL, 0); | ||
| printf(\"$lib_version\")" | ||
| . auto/feature | ||
| fi |
There was a problem hiding this comment.
Will you please explain these changes? I prefer minimal changes. Thanks!
|
PostgreSQL 9.2 released more then 4 years ago! I didn't seen questions for older then 9.4 version for a year on pgsql-admin. We have check per 9.1 and thats even an overkill. Longer check list makes config file harder to understand. Original config was made 6 years ago, many things changed in the world since then! There no any logical reason to support check per 8.0 postgresql version |
|
@cryptofuture Pull requests should be atomic and minimized. It's not good practice to include unrelated changes. If you think we should drop version checks against older Pg, then it deserves a separate dedicated pull request I'm afraid. |
|
@cryptofuture: thank you for your work! Do you have time to split this PR into two separate ones as requested by @agentzh? |
|
I'm interested in this feature. Is this PR still alive? |
Tested in production. I also updated version checks.