Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lib: Load built-in Lua functions #16907

Merged
merged 2 commits into from
Sep 24, 2024
Merged

lib: Load built-in Lua functions #16907

merged 2 commits into from
Sep 24, 2024

Conversation

ton31337
Copy link
Member

@ton31337 ton31337 commented Sep 24, 2024 •
edited
Loading

Closes #16900

@ton31337
lib: Load built-in Lua functions
4b0f4f9 
We can't use even `string()` function because built-in functions are not
loaded.

Testing with:

```
$ cat /etc/frr/scripts/zebra.lua
function on_rib_process_dplane_results(ctx)
	log.warn(string.upper("testas"))
	return {}
end
```

This results to "TESTAS" in the logs.

Signed-off-by: Donatas Abraitis <[email protected]>
@frrbot frrbot bot added the libfrr label Sep 24, 2024
This was referenced Sep 24, 2024
Closed
Closed
@frrbot frrbot bot added the tests Topotests, make check, etc label Sep 24, 2024
@github-actions github-actions bot added size/S and removed size/XS labels Sep 24, 2024
@ton31337 ton31337 force-pushed the fix/load_built-in_lua_functions branch from 5a20edd to 623fb6d Compare September 24, 2024 10:40
riw777
riw777 approved these changes Sep 24, 2024
View reviewed changes
Copy link
Member

@riw777 riw777 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@riw777 riw777 merged commit 5cf4af6 into FRRouting:master Sep 24, 2024
11 checks passed
@ton31337 ton31337 deleted the fix/load_built-in_lua_functions branch September 24, 2024 14:58
k0ste added a commit to k0ste/ansible-role-frr that referenced this pull request Oct 29, 2024
@k0ste
Added support for FRR LUA scripting
0df8f90 
See: https://docs.frrouting.org/en/latest/scripting.html

* FRRouting/frr#16907
* FRRouting/frr#17160
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@riw777 riw777 riw777 approved these changes

Assignees
No one assigned
Labels
libfrr master size/S tests Topotests, make check, etc
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Lua is loaded into an empty namespace, preventing key Lua functions
2 participants
@ton31337 @riw777