Disable DFCO when clutch is applied #487
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mck1117
reviewed
Sep 17, 2024
| @@ -71,6 +71,8 @@ enum class SensorType : unsigned char { | |||
|
|
|||
| BarometricPressure, | |||
|
|
|||
| ClutchUp, | |||
There was a problem hiding this comment.
Good catch. Initially thought I needed to plumb it through before I saw that the digital inputs were getting set in engine.cpp. This can/should be removed
mck1117
reviewed
Sep 17, 2024
| @@ -109,6 +109,7 @@ static void setDefaultFuelCutParameters() { | |||
| engineConfiguration->coastingFuelCutTps = 2; | |||
| engineConfiguration->coastingFuelCutMap = 30; | |||
| engineConfiguration->coastingFuelCutClt = 60; | |||
| engineConfiguration->disableFuelCutOnClutch = false; | |||
There was a problem hiding this comment.
By the way, you don't have to set any defaults that have a bit value of 0. The configuration is zeroed before reset, so everything defaults to 0/false/etc.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow clutchUp switch to be a gating term for fuel cut activation. Enables feature requested in #22