disable injection/ignition trim tables for cylinders > cyl_count #473
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rusefillc
reviewed
Aug 26, 2024
| groupChildMenu = fuelTrimTbl10, "Fuel trim cyl 10" | ||
| groupChildMenu = fuelTrimTbl11, "Fuel trim cyl 11" | ||
| groupChildMenu = fuelTrimTbl12, "Fuel trim cyl 12" | ||
| groupChildMenu = fuelTrimTbl1, "Fuel trim cyl 1" { isInjectionEnabled == 1 && cylindersCount >= 1 } |
There was a problem hiding this comment.
@alrijleh any chance you are missing commas?
There was a problem hiding this comment.
Hmm I see what you mean. I'm surprised since the generated ini works as expected on my end. I can add those in
There was a problem hiding this comment.
Hmm I see what you mean. I'm surprised since the generated ini works as expected on my end. I can add those in
Maybe these commas are optional on purpose, maybe a happy TS bug
There was a problem hiding this comment.
the TS ini parser is very....interesting
|
you probably actually need a |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No need to adjust fuel trim for cylinder 12 on a 4 cylinder miata