TunerStudio command x14 cleanup #434
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nmschulte
commented
May 29, 2024
nmschulte
commented
May 29, 2024
| TS_COMMAND_14 = 14, | ||
| TS_COMMAND_15 = 15, | ||
| TS_COMMAND_16 = 16, | ||
| TS_UNUSED_1 = 1, |
nmschulte
commented
May 29, 2024
| TS_UNUSED_13 = 13, | ||
| TS_UNUSED_14 = 14, | ||
| TS_UNUSED_15 = 15, | ||
| TS_UNUSED_16 = 16, | ||
| TS_CLEAR_WARNINGS = 17, | ||
| TS_IGNITION_CATEGORY = 18, | ||
| TS_INJECTOR_CATEGORY = 19, | ||
| TS_X14 = 20, |
There was a problem hiding this comment.
Why is 0x14 "subbed"? Was this a mechanism to extend the space or something?
This "top level" test command space is used on line 417 of this branch: https://github.com/FOME-Tech/fome-fw/pull/434/files#diff-2bc64a65850292065d75a8ce8029fdbc338eeb43d7049d3c2cbc545be73085ddR417
nmschulte
force-pushed
the
nms/tunerstudio-command-x14-cleanup
branch
from
b9cff6f to
618530e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tidy indent/IFDEFmacros in DC motorsuse ADC conversion function in ETBas far as I can tell, this should result in no breaking changes for FOME: no commands changed value/ID, and no releases/bundles exposed the
cmd_calibrate_tps*symbols.