Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent posting plugin #313

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

thessakranendonk
Copy link

@thessakranendonk thessakranendonk commented Nov 12, 2022

PR for issue #312: Warning about bad dock_image tag name does not prevent upload
and the warning shows up only for a brief amount of time before a successful upload sign replaces it.

  • Fixed POST request form being sent if form is not populated to satisfaction.
  • Fixed error message disappearing after a few seconds
  • Fixed wrong error message display (message: Please enter the Docker Image and Public Repo. But repo is correct.)
  • Added disabling of submit button until all text input fields are populated
  • Changed error message display location from the top of the form to the corresponding field to match other forms UI in ChRIS_ui and ChRIS_store_ui.

Before:
Screen Shot 2022-11-12 at 3 18 16 PM
Screen Shot 2022-11-12 at 3 16 00 PM

After:
Screen Shot 2022-11-12 at 3 19 02 PM
Screen Shot 2022-11-12 at 3 16 46 PM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant