Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warning about bad dock_image tag name does not prevent upload. #312

Open
jennydaman opened this issue Nov 9, 2022 · 1 comment
Open
Labels
bug Something isn't working enhancement Something to be improved good first issue Good for newcomers

Comments

@jennydaman
Copy link
Collaborator

this.handleError(
<div>
<p>
Please tag your Docker image by version.
<br />
Example:
</p>
<CodeBlock>
<CodeBlockCode>
docker tag
{tag}
{tag}
:1.0.1
<br />
docker push
{tag}
:1.0.1
</CodeBlockCode>
</CodeBlock>
</div>,

A warning is shown if the user-specified value for dock_image violates best practices, however this warning does not prevent the POST request form being sent, and the warning shows up only for a brief amount of time before a successful upload sign replaces it.

Expected: warning about dock_image best practice shows up and prevents the POST request from being sent.

@jennydaman jennydaman added bug Something isn't working enhancement Something to be improved good first issue Good for newcomers labels Nov 9, 2022
@thessakranendonk
Copy link

I'd like to work on this one :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement Something to be improved good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants