Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pipeline upload screen #224

Open
jennydaman opened this issue Jun 17, 2021 · 3 comments
Open

Pipeline upload screen #224

jennydaman opened this issue Jun 17, 2021 · 3 comments
Assignees
Labels
enhancement Something to be improved help wanted Extra attention is needed
Milestone

Comments

@jennydaman
Copy link
Collaborator

jennydaman commented Jun 17, 2021

The ChRIS_store backend supports POST request to create and store pipelines (a chain of multiple plugins, with parameters). We need to implement a user interface for creating plugins.

Easiest solution: allow pipeline JSON to be uploaded. Front-end makes a POST request to chrisstore.co/api/v1/pipelines/.
Example: https://github.com/FNNDSC/CHRIS_docs/blob/master/pipelines/fetal_brain_reconstruction.sh

We are debating a new proposal: add a page featuring a drag-and-drop interface where users can design pipelines in the ChRIS_store_ui. If logged in, user should be able to save the pipeline to the ChRIS_store.
Ideally, the widget for this should be coded up as a reusable React component — one day we might want to port it into https://github.com/FNNDSC/ChRIS_ui/

Arguments against the new proposal: user cannot execute test-run of pipelines designed in the ChRIS_store_ui without importing the pipeline into ChRIS first. The feature of designing pipelines should only be available in ChRIS_ui, and the only way to upload pipelines to the ChRIS_store should be via a publish or import/export mechanism invoked from ChRIS.

Regarding above, see FNNDSC/ChRIS_ui#269

@jennydaman jennydaman added enhancement Something to be improved help wanted Extra attention is needed labels Jun 17, 2021
@jennydaman
Copy link
Collaborator Author

Related to #223

@jennydaman jennydaman added this to the 2.0 reach milestone Jun 17, 2021
@jennydaman jennydaman changed the title Pipeline creation drag-and-drop Pipeline creation Jun 17, 2021
@jennydaman jennydaman changed the title Pipeline creation Pipeline upload screen Jun 18, 2021
@mairin mairin assigned mairin and unassigned mairin Jan 24, 2022
@mairin
Copy link
Contributor

mairin commented Jan 24, 2022

@EUGINELETHAL This is something you're working on now, is that correct? Is it tracked in another issue or would you like to self-assign here?

@EUGINELETHAL
Copy link
Contributor

yah am working on this right now, and yes I can self-assign it here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Something to be improved help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

4 participants