build: fix dependency on SDL2 #335
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a followup on 81d5a24 (build: fix building with MSVC, 2024-03-07) and 68a555e (build: fix __attribute__((aligned(x))) on gcc/clang, 2024-03-09) for the purposes of creating a vcpkg FAudio port. Add a `Requires.private: sdl2` to the pkgconf file for the SDL2 dependency when not using PLATFORM_WIN32. Add the SDL2 dependency to the generated cmake config file when not using PLATFORM_WIN32 as well. Signed-off-by: Rafael Kitover <[email protected]>
rkitover
added a commit
to rkitover/vcpkg
that referenced
this pull request
Mar 10, 2024
Add new port FAudio, an "accuracy-focused XAudio reimplementation for open platforms". Use the PLATFORM_WIN32 cmake flag on Windows, otherwise use the sdl2 dependency. MSVC build PR is here: FNA-XNA/FAudio#333 , followup PR to fix alignment is here: FNA-XNA/FAudio#334 , and another followup for the SDL2 dependency: FNA-XNA/FAudio#335 , the MSYS2 package is here: https://github.com/msys2/MINGW-packages/blob/master/mingw-w64-faudio/PKGBUILD . Signed-off-by: Rafael Kitover <[email protected]>
|
@flibitijibibo wanted to give you an update, my faudio port for vcpkg has been merged, and I also fixed the MSYS2 faudio package to use |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a followup on 81d5a24 (build: fix building with MSVC, 2024-03-07) and 68a555e (build: fix attribute((aligned(x))) on gcc/clang, 2024-03-09) for the purposes of creating a vcpkg FAudio port.
Add a
Requires.private: sdl2to the pkgconf file for the SDL2 dependency when not using PLATFORM_WIN32.Add the SDL2 dependency to the generated cmake config file when not using PLATFORM_WIN32 as well.