VMO-4138 Unified Message Block #109

poojahpatil90 · 2021-07-08T01:20:39Z

Note: I need to add a few icons in the resources part. Waiting for the design team to provide the icons as it was not downloadable from the Figma link provided.

Screen.Recording.2021-07-07.at.6.17.29.PM.mov

Update: Added icons and dividers

Screen.Recording.2021-07-08.at.5.14.52.PM.mov

Update: After fixing review comments + adding block semantic label

github-actions · 2021-07-09T00:17:48Z

src/components/interaction-designer/resource-editors/ResourceEditor.vue

@@ -1,92 +1,89 @@
 <template>
-  <div class="resource-editor">
-    <hr v-if="label">
+  <div class="resource-editor" v-if="flow.languages.length > 0">


Reporter: ESLint
Rule: eslint.rules.vue/max-attributes-per-line
Severity: WARN
File: src/components/interaction-designer/resource-editors/ResourceEditor.vue L2

'v-if' should be on a new line. (vue/max-attributes-per-line)

github-actions · 2021-07-09T00:17:48Z

src/components/interaction-designer/resource-editors/ResourceEditor.vue

@@ -1,92 +1,89 @@
 <template>
-  <div class="resource-editor">
-    <hr v-if="label">
+  <div class="resource-editor" v-if="flow.languages.length > 0">


Reporter: ESLint
Rule: eslint.rules.vue/attributes-order
Severity: WARN
File: src/components/interaction-designer/resource-editors/ResourceEditor.vue L2

Attribute "v-if" should go before "class". (vue/attributes-order)

# Resolved Conflicts: # tests/unit/__snapshots__/storybook.spec.ts.snap

bzabos

Hi @poojahpatil90! Nice one, this looks good! I have left a couple minor comments.

One curiosity thing: The pink/primary colour on the design seems to be more pinky/fuchsia-y I'm guessing I missed some discussions, but I'm wondering if those should match!

src/components/common/AudioLibrarySearchField.vue

src/components/interaction-designer/resource-editors/ResourceEditor.vue

src/store/flow/block.ts

src/components/common/SvgIcon.vue

bzabos · 2021-07-09T14:56:41Z

Hi @poojahpatil90, I'm just looking a bit more closely at the design a bit closer and I noticed two things:

There's a small edit button next to the code as a label which is what someone should click to edit?
Block semantic label: I'm confused as to whether this should be showing up under categorization below or up by the block name— I'm seeing it in both places, but under categorization makes the most sense to me

poojahpatil90 · 2021-07-09T15:43:37Z

@asalami Please review the design for this PR.

poojahpatil90 · 2021-07-11T20:03:44Z

Hi @poojahpatil90, I'm just looking a bit more closely at the design a bit closer and I noticed two things:

There's a small edit button next to the code as a label which is what someone should click to edit?

Block semantic label: I'm confused as to whether this should be showing up under categorization below or up by the block name— I'm seeing it in both places, but under categorization makes the most sense to me

@bzabos As discussed on Friday, I seemed to have used an older version of the UX. I made changes to include the edit button and block semantic label.

poojahpatil90 · 2021-07-11T20:08:09Z

Hi @poojahpatil90! Nice one, this looks good! I have left a couple minor comments.

One curiosity thing: The pink/primary colour on the design seems to be more pinky/fuchsia-y I'm guessing I missed some discussions, but I'm wondering if those should match!

@bzabos as seen in the image above, I had used the color on the left hand side which seems to be a darker shade than the one on right hand side. I am not sure which is the right color though 🤷🏽‍♀️. Good thing is that we can change it in just one place now (custom_variables.scss). I have changed it to the lighter shade (attached an updated screenshot). Let me know your thoughts.

@asalami Any thoughts on which color should be used here?

github-actions · 2021-07-13T19:58:29Z

src/lib/custom-icons/index.ts

+    32,
+    [],
+    'e006',
+    'M17.9279 23.5201L18.6005 24.2601L18.6005 24.2601L17.9279 23.5201ZM13 28H12V30.2606L13.6727 28.7399L13 28ZM13 23H14V22H13V23ZM13.25 11C13.25 10.4477 12.8023 10 12.25 10C11.6977 10 11.25 10.4477 11.25 11H13.25ZM11.25 17.5C11.25 18.0523 11.6977 18.5 12.25 18.5C12.8023 18.5 13.25 18.0523 13.25 17.5H11.25ZM10.659 11.2448C10.2685 10.8543 9.63532 10.8543 9.2448 11.2448C8.85427 11.6353 8.85427 12.2685 9.2448 12.659L10.659 11.2448ZM13.841 17.2552C14.2315 17.6457 14.8647 17.6457 15.2552 17.2552C15.6457 16.8647 15.6457 16.2315 15.2552 15.841L13.841 17.2552ZM9 13.25C8.44772 13.25 8 13.6977 8 14.25C8 14.8023 8.44772 15.25 9 15.25V13.25ZM15.5 15.25C16.0523 15.25 16.5 14.8023 16.5 14.25C16.5 13.6977 16.0523 13.25 15.5 13.25V15.25ZM15.2552 12.659C15.6457 12.2685 15.6457 11.6353 15.2552 11.2448C14.8647 10.8543 14.2315 10.8543 13.841 11.2448L15.2552 12.659ZM9.24479 15.841C8.85427 16.2315 8.85427 16.8647 9.24479 17.2552C9.63532 17.6457 10.2685 17.6457 10.659 17.2552L9.24479 15.841ZM20.9884 11.1521C21.0724 10.6062 20.6979 10.0956 20.1521 10.0116C19.6062 9.92765 19.0956 10.3021 19.0116 10.8479L20.9884 11.1521ZM18.0116 17.3479C17.9276 17.8938 18.3021 18.4044 18.8479 18.4884C19.3938 18.5724 19.9044 18.1979 19.9884 17.6521L18.0116 17.3479ZM23.9884 11.1521C24.0724 10.6062 23.6979 10.0956 23.1521 10.0116C22.6062 9.92765 22.0956 10.3021 22.0116 10.8479L23.9884 11.1521ZM21.0116 17.3479C20.9276 17.8938 21.3021 18.4044 21.8479 18.4884C22.3938 18.5724 22.9044 18.1979 22.9884 17.6521L21.0116 17.3479ZM18 12C17.4477 12 17 12.4477 17 13C17 13.5523 17.4477 14 18 14V12ZM24 14C24.5523 14 25 13.5523 25 13C25 12.4477 24.5523 12 24 12V14ZM18 15C17.4477 15 17 15.4477 17 16C17 16.5523 17.4477 17 18 17V15ZM24 17C24.5523 17 25 16.5523 25 16C25 15.4477 24.5523 15 24 15V17ZM7 6H26V4H7V6ZM27 7V21H29V7H27ZM6 21V7H4V21H6ZM26 22H19.2732V24H26V22ZM4 21C4 22.6569 5.34315 24 7 24V22C6.44771 22 6 21.5523 6 21H4ZM27 21C27 21.5523 26.5523 22 26 22V24C27.6569 24 29 22.6569 29 21H27ZM26 6C26.5523 6 27 6.44772 27 7H29C29 5.34315 27.6569 4 26 4V6ZM7 4C5.34315 4 4 5.34315 4 7H6C6 6.44772 6.44772 6 7 6V4ZM17.2552 22.7802L12.3273 27.2601L13.6727 28.7399L18.6005 24.2601L17.2552 22.7802ZM14 28V23H12V28H14ZM19.2732 22C18.5269 22 17.8074 22.2782 17.2552 22.7802L18.6005 24.2601C18.7846 24.0927 19.0244 24 19.2732 24V22ZM11.25 11V14.25H13.25V11H11.25ZM11.25 14.25V17.5H13.25V14.25H11.25ZM9.2448 12.659L11.5429 14.9571L12.9571 13.5429L10.659 11.2448L9.2448 12.659ZM11.5429 14.9571L13.841 17.2552L15.2552 15.841L12.9571 13.5429L11.5429 14.9571ZM9 15.25H12.25V13.25H9V15.25ZM12.25 15.25H15.5V13.25H12.25V15.25ZM13.841 11.2448L11.5429 13.5429L12.9571 14.9571L15.2552 12.659L13.841 11.2448ZM11.5429 13.5429L9.24479 15.841L10.659 17.2552L12.9571 14.9571L11.5429 13.5429ZM19.0116 10.8479L18.7039 12.8479L20.6807 13.1521L20.9884 11.1521L19.0116 10.8479ZM18.7039 12.8479L18.2424 15.8479L20.2191 16.1521L20.6807 13.1521L18.7039 12.8479ZM18.2424 15.8479L18.0116 17.3479L19.9884 17.6521L20.2191 16.1521L18.2424 15.8479ZM22.0116 10.8479L21.7039 12.8479L23.6807 13.1521L23.9884 11.1521L22.0116 10.8479ZM21.7039 12.8479L21.2424 15.8479L23.2191 16.1521L23.6807 13.1521L21.7039 12.8479ZM21.2424 15.8479L21.0116 17.3479L22.9884 17.6521L23.2191 16.1521L21.2424 15.8479ZM18 14H19.6923V12H18V14ZM19.6923 14H22.6923V12H19.6923V14ZM22.6923 14H24V12H22.6923V14ZM18 17H19.2308V15H18V17ZM19.2308 17H22.2308V15H19.2308V17ZM22.2308 17H24V15H22.2308V17ZM13 22H7V24H13V22Z',


Reporter: ESLint
Rule: eslint.rules.max-len
Severity: WARN
File: src/lib/custom-icons/index.ts L75

This line has a length of 3420. Maximum allowed is 140. (max-len)

github-actions · 2021-07-13T19:58:30Z

src/lib/custom-icons/index.ts

+    16,
+    [],
+    'e004',
+    'M14.9757 7.00154L13.2241 5.81525L13.6254 3.73557C13.7015 3.34893 13.5785 2.95057 13.3002 2.66938C13.019 2.39111 12.6207 2.26809 12.2399 2.34424L10.1632 2.74553L8.97979 0.990993C8.53749 0.3378 7.45958 0.3378 7.01728 0.990993L5.83392 2.74553L3.76011 2.34424C3.37053 2.27102 2.9751 2.39111 2.69684 2.67231C2.41857 2.9535 2.29555 3.34893 2.3717 3.73557L2.77299 5.81525L1.02138 7.00154C0.693322 7.22415 0.5 7.59029 0.5 7.98572C0.5 8.38115 0.696251 8.74729 1.02138 8.96697L2.77299 10.1533L2.3717 12.2329C2.29555 12.6196 2.41857 13.0179 2.69684 13.2962C2.9751 13.5745 3.3676 13.6975 3.76011 13.6213L5.83392 13.2201L7.01728 14.9746C7.23697 15.3027 7.60603 15.4989 7.99854 15.4989C8.39104 15.4989 8.76011 15.3027 8.97979 14.9775L10.1632 13.223L12.2399 13.6243C12.6324 13.7034 13.0249 13.5774 13.3032 13.2991C13.5814 13.0209 13.7015 12.6225 13.6283 12.2359L13.227 10.1562L14.9786 8.9699C15.3037 8.75022 15.5 8.38115 15.5 7.98865C15.4971 7.59029 15.3037 7.22415 14.9757 7.00154ZM11.6687 9.50886L12.1842 12.1802L9.51875 11.6647L7.99854 13.9172L6.47832 11.6618L3.81576 12.1773L4.33128 9.50593L2.08172 7.98279L4.33128 6.45965L3.81576 3.7883L6.48125 4.30382L7.99854 2.05426L9.51875 4.30675L12.1842 3.79123L11.6687 6.45965L13.9183 7.98279L11.6687 9.50886ZM7.99854 4.95409C6.32015 4.95409 4.95226 6.32198 4.95226 8.00037C4.95226 9.67875 6.32015 11.0466 7.99854 11.0466C9.67692 11.0466 11.0448 9.67875 11.0448 8.00037C11.0448 6.32198 9.67692 4.95409 7.99854 4.95409ZM7.99854 9.64067C7.09344 9.64067 6.35823 8.90546 6.35823 8.00037C6.35823 7.09527 7.09344 6.36006 7.99854 6.36006C8.90363 6.36006 9.63884 7.09527 9.63884 8.00037C9.63884 8.90546 8.90363 9.64067 7.99854 9.64067Z'


Reporter: ESLint
Rule: eslint.rules.comma-dangle
Severity: ERROR
File: src/lib/custom-icons/index.ts L51

Missing trailing comma. (comma-dangle)

github-actions · 2021-07-13T19:58:31Z

src/lib/custom-icons/index.ts

+    16,
+    [],
+    'e004',
+    'M14.9757 7.00154L13.2241 5.81525L13.6254 3.73557C13.7015 3.34893 13.5785 2.95057 13.3002 2.66938C13.019 2.39111 12.6207 2.26809 12.2399 2.34424L10.1632 2.74553L8.97979 0.990993C8.53749 0.3378 7.45958 0.3378 7.01728 0.990993L5.83392 2.74553L3.76011 2.34424C3.37053 2.27102 2.9751 2.39111 2.69684 2.67231C2.41857 2.9535 2.29555 3.34893 2.3717 3.73557L2.77299 5.81525L1.02138 7.00154C0.693322 7.22415 0.5 7.59029 0.5 7.98572C0.5 8.38115 0.696251 8.74729 1.02138 8.96697L2.77299 10.1533L2.3717 12.2329C2.29555 12.6196 2.41857 13.0179 2.69684 13.2962C2.9751 13.5745 3.3676 13.6975 3.76011 13.6213L5.83392 13.2201L7.01728 14.9746C7.23697 15.3027 7.60603 15.4989 7.99854 15.4989C8.39104 15.4989 8.76011 15.3027 8.97979 14.9775L10.1632 13.223L12.2399 13.6243C12.6324 13.7034 13.0249 13.5774 13.3032 13.2991C13.5814 13.0209 13.7015 12.6225 13.6283 12.2359L13.227 10.1562L14.9786 8.9699C15.3037 8.75022 15.5 8.38115 15.5 7.98865C15.4971 7.59029 15.3037 7.22415 14.9757 7.00154ZM11.6687 9.50886L12.1842 12.1802L9.51875 11.6647L7.99854 13.9172L6.47832 11.6618L3.81576 12.1773L4.33128 9.50593L2.08172 7.98279L4.33128 6.45965L3.81576 3.7883L6.48125 4.30382L7.99854 2.05426L9.51875 4.30675L12.1842 3.79123L11.6687 6.45965L13.9183 7.98279L11.6687 9.50886ZM7.99854 4.95409C6.32015 4.95409 4.95226 6.32198 4.95226 8.00037C4.95226 9.67875 6.32015 11.0466 7.99854 11.0466C9.67692 11.0466 11.0448 9.67875 11.0448 8.00037C11.0448 6.32198 9.67692 4.95409 7.99854 4.95409ZM7.99854 9.64067C7.09344 9.64067 6.35823 8.90546 6.35823 8.00037C6.35823 7.09527 7.09344 6.36006 7.99854 6.36006C8.90363 6.36006 9.63884 7.09527 9.63884 8.00037C9.63884 8.90546 8.90363 9.64067 7.99854 9.64067Z'


Reporter: ESLint
Rule: eslint.rules.max-len
Severity: WARN
File: src/lib/custom-icons/index.ts L51

This line has a length of 1663. Maximum allowed is 140. (max-len)

github-actions · 2021-07-13T19:58:32Z

src/lib/custom-icons/index.ts

+    32,
+    [],
+    'e003',
+    'M7.99805 13.9376C7.9636 13.3864 7.48883 12.9675 6.93762 13.0019C6.38641 13.0364 5.9675 13.5112 6.00195 14.0624L7.99805 13.9376ZM25.9981 14.0624C26.0325 13.5112 25.6136 13.0364 25.0624 13.0019C24.5112 12.9675 24.0364 13.3864 24.0019 13.9376L25.9981 14.0624ZM15 28C15 28.5523 15.4477 29 16 29C16.5523 29 17 28.5523 17 28H15ZM8 27C7.44772 27 7 27.4477 7 28C7 28.5523 7.44772 29 8 29V27ZM24 29C24.5523 29 25 28.5523 25 28C25 27.4477 24.5523 27 24 27V29ZM20 8V13H22V8H20ZM12 13V8H10V13H12ZM16 17C13.7909 17 12 15.2091 12 13H10C10 16.3137 12.6863 19 16 19V17ZM20 13C20 15.2091 18.2091 17 16 17V19C19.3137 19 22 16.3137 22 13H20ZM16 4C18.2091 4 20 5.79086 20 8H22C22 4.68629 19.3137 2 16 2V4ZM16 2C12.6863 2 10 4.68629 10 8H12C12 5.79086 13.7909 4 16 4V2ZM6.00195 14.0624C6.09611 15.5689 6.7059 17.7811 8.24207 19.6375C9.81064 21.5331 12.3011 23 16 23V21C12.8989 21 10.9727 19.8003 9.78293 18.3625C8.56077 16.8855 8.07056 15.0977 7.99805 13.9376L6.00195 14.0624ZM16 23C19.6989 23 22.1894 21.5331 23.7579 19.6375C25.2941 17.7811 25.9039 15.5689 25.9981 14.0624L24.0019 13.9376C23.9294 15.0977 23.4392 16.8855 22.2171 18.3625C21.0273 19.8003 19.1011 21 16 21V23ZM17 28V22H15V28H17ZM8 29H24V27H8V29Z'


Reporter: ESLint
Rule: eslint.rules.comma-dangle
Severity: ERROR
File: src/lib/custom-icons/index.ts L39

Missing trailing comma. (comma-dangle)

github-actions · 2021-07-15T23:19:18Z

src/components/interaction-designer/block-editors/NameEditor.vue

+          <h6 class="d-inline">{{'flow-builder.code' | trans}}:</h6>
+          <span> {{ blockName }} </span>
+        </div>
+        <span class="btn btn-primary btn-xs align-self-baseline ml-2" @click="editBlockName = true">


Reporter: ESLint
Rule: eslint.rules.vue/max-attributes-per-line
Severity: WARN
File: src/components/interaction-designer/block-editors/NameEditor.vue L30

'@click' should be on a new line. (vue/max-attributes-per-line)

github-actions · 2021-07-15T23:19:19Z

src/components/interaction-designer/block-editors/NameEditor.vue

+      </div>
+      <div v-else class="d-flex justify-content-between">
+        <div class="block-code align-self-center">
+          <h6 class="d-inline">{{'flow-builder.code' | trans}}:</h6>


Reporter: ESLint
Rule: eslint.rules.vue/singleline-html-element-content-newline
Severity: WARN
File: src/components/interaction-designer/block-editors/NameEditor.vue L27

Expected 1 line break after opening tag (`<h6>`), but no line breaks found. (vue/singleline-html-element-content-newline)

github-actions · 2021-07-15T23:19:19Z

src/components/interaction-designer/block-editors/NameEditor.vue

+      </div>
+      <div v-else class="d-flex justify-content-between">
+        <div class="block-code align-self-center">
+          <h6 class="d-inline">{{'flow-builder.code' | trans}}:</h6>


Reporter: ESLint
Rule: eslint.rules.vue/singleline-html-element-content-newline
Severity: WARN
File: src/components/interaction-designer/block-editors/NameEditor.vue L27

Expected 1 line break before closing tag (`</h6>`), but no line breaks found. (vue/singleline-html-element-content-newline)

github-actions · 2021-07-15T23:19:20Z

src/components/interaction-designer/block-editors/NameEditor.vue

+      </div>
+      <div v-else class="d-flex justify-content-between">
+        <div class="block-code align-self-center">
+          <h6 class="d-inline">{{'flow-builder.code' | trans}}:</h6>


Reporter: ESLint
Rule: eslint.rules.vue/mustache-interpolation-spacing
Severity: WARN
File: src/components/interaction-designer/block-editors/NameEditor.vue L27

Expected 1 space after '{{', but not found. (vue/mustache-interpolation-spacing)

github-actions · 2021-07-15T23:19:20Z

src/components/interaction-designer/block-editors/NameEditor.vue

+      </div>
+      <div v-else class="d-flex justify-content-between">
+        <div class="block-code align-self-center">
+          <h6 class="d-inline">{{'flow-builder.code' | trans}}:</h6>


Reporter: ESLint
Rule: eslint.rules.vue/mustache-interpolation-spacing
Severity: WARN
File: src/components/interaction-designer/block-editors/NameEditor.vue L27

Expected 1 space before '}}', but not found. (vue/mustache-interpolation-spacing)

github-actions · 2021-07-15T23:19:21Z

src/components/interaction-designer/block-editors/NameEditor.vue

+          </span>
+        </div>
+      </div>
+      <div v-else class="d-flex justify-content-between">


Reporter: ESLint
Rule: eslint.rules.vue/max-attributes-per-line
Severity: WARN
File: src/components/interaction-designer/block-editors/NameEditor.vue L25

'class' should be on a new line. (vue/max-attributes-per-line)

github-actions · 2021-07-15T23:19:22Z

src/components/interaction-designer/block-editors/NameEditor.vue

-  </validation-message>
+  <div class="mt-3">
+    <validation-message
+      #input-control="{ isValid }"


Reporter: ESLint
Rule: eslint.rules.vue/valid-v-slot
Severity: ERROR
File: src/components/interaction-designer/block-editors/NameEditor.vue L4

Named slots must use '<template>' on a custom element. (vue/valid-v-slot)

github-actions · 2021-07-15T23:19:23Z

src/components/interaction-designer/block-types/ConsoleIO_ReadBlock.vue

@@ -82,6 +86,8 @@ class ConsoleIO_ReadBlock extends mixins(Lang) {

  @Prop() readonly declare flow: IFlow

+  showSemanticLabel = false
+
  filterVariableName(e: any) {
    if (e.key.match(/\W+|Enter/g)) {


Reporter: ESLint
Rule: eslint.rules.@typescript-eslint/strict-boolean-expressions
Severity: ERROR
File: src/components/interaction-designer/block-types/ConsoleIO_ReadBlock.vue L92

Unexpected any value in conditional. An explicit comparison or type cast is required. (@typescript-eslint/strict-boolean-expressions)

github-actions · 2021-07-15T23:19:23Z

src/components/interaction-designer/block-types/ConsoleIO_ReadBlock.vue

@@ -82,6 +86,8 @@ class ConsoleIO_ReadBlock extends mixins(Lang) {

  @Prop() readonly declare flow: IFlow

+  showSemanticLabel = false
+
  filterVariableName(e: any) {


Reporter: ESLint
Rule: eslint.rules.@typescript-eslint/explicit-module-boundary-types
Severity: WARN
File: src/components/interaction-designer/block-types/ConsoleIO_ReadBlock.vue L91

Argument 'e' should be typed with a non-any type. (@typescript-eslint/explicit-module-boundary-types)

github-actions · 2021-07-15T23:19:24Z

src/components/interaction-designer/block-types/ConsoleIO_ReadBlock.vue

@@ -82,6 +86,8 @@ class ConsoleIO_ReadBlock extends mixins(Lang) {

  @Prop() readonly declare flow: IFlow

+  showSemanticLabel = false
+
  filterVariableName(e: any) {


Reporter: ESLint
Rule: eslint.rules.@typescript-eslint/explicit-function-return-type
Severity: WARN
File: src/components/interaction-designer/block-types/ConsoleIO_ReadBlock.vue L91

Missing return type on function. (@typescript-eslint/explicit-function-return-type)

github-actions · 2021-07-15T23:19:25Z

src/components/interaction-designer/block-types/ConsoleIO_ReadBlock.vue

@@ -82,6 +86,8 @@ class ConsoleIO_ReadBlock extends mixins(Lang) {

  @Prop() readonly declare flow: IFlow

+  showSemanticLabel = false
+
  filterVariableName(e: any) {


Reporter: ESLint
Rule: eslint.rules.@typescript-eslint/explicit-module-boundary-types
Severity: WARN
File: src/components/interaction-designer/block-types/ConsoleIO_ReadBlock.vue L91

Missing return type on function. (@typescript-eslint/explicit-module-boundary-types)

github-actions · 2021-07-15T23:19:25Z

src/components/interaction-designer/block-types/ConsoleIO_ReadBlock.vue

@@ -82,6 +86,8 @@ class ConsoleIO_ReadBlock extends mixins(Lang) {

  @Prop() readonly declare flow: IFlow

+  showSemanticLabel = false
+
  filterVariableName(e: any) {


Reporter: ESLint
Rule: eslint.rules.@typescript-eslint/no-explicit-any
Severity: WARN
File: src/components/interaction-designer/block-types/ConsoleIO_ReadBlock.vue L91

Unexpected any. Specify a different type. (@typescript-eslint/no-explicit-any)

github-actions · 2021-07-15T23:19:26Z

src/components/interaction-designer/block-types/Core_CaseBlock.vue

      <block-name-editor :block="block" />
-      <block-label-editor :block="block" />
-      <block-semantic-label-editor :block="block" />

      <div


Reporter: ESLint
Rule: eslint.rules.vue/require-v-for-key
Severity: ERROR
File: src/components/interaction-designer/block-types/Core_CaseBlock.vue L16

Elements in iteration expect to have 'v-bind:key' directives. (vue/require-v-for-key)

github-actions · 2021-07-15T23:19:27Z

src/components/interaction-designer/block-types/Core_OutputBlock.vue

      <block-name-editor :block="block" />
-      <block-label-editor :block="block" />
-      <block-semantic-label-editor :block="block" />

      <validation-message
        #input-control="{ isValid }"


Reporter: ESLint
Rule: eslint.rules.vue/valid-v-slot
Severity: ERROR
File: src/components/interaction-designer/block-types/Core_OutputBlock.vue L17

Named slots must use '<template>' on a custom element. (vue/valid-v-slot)

github-actions · 2021-07-15T23:19:27Z

src/components/interaction-designer/block-types/Core_RunFlowBlock.vue

      <block-name-editor :block="block" />
-      <block-label-editor :block="block" />
-      <block-semantic-label-editor :block="block" />

      <validation-message
        #input-control="{ isValid }"


Reporter: ESLint
Rule: eslint.rules.vue/valid-v-slot
Severity: ERROR
File: src/components/interaction-designer/block-types/Core_RunFlowBlock.vue L16

Named slots must use '<template>' on a custom element. (vue/valid-v-slot)

github-actions · 2021-07-15T23:19:28Z

src/components/interaction-designer/block-types/Core_SetGroupMembershipBlock.vue

      <block-name-editor :block="block" />
-      <block-label-editor :block="block" />
-      <block-semantic-label-editor :block="block" />

      <validation-message
        #input-control="{ isValid: isValid }"


Reporter: ESLint
Rule: eslint.rules.vue/valid-v-slot
Severity: ERROR
File: src/components/interaction-designer/block-types/Core_SetGroupMembershipBlock.vue L17

Named slots must use '<template>' on a custom element. (vue/valid-v-slot)

github-actions · 2021-07-15T23:19:29Z

src/components/interaction-designer/block-types/MobilePrimitives_SelectManyResponseBlock.vue

@@ -97,6 +101,8 @@ const builderVuexNamespace = namespace('builder')
  },
 })
 export class MobilePrimitives_SelectManyResponseBlock extends SelectOneResponseBlock {
+  showSemanticLabel = false
+
  //Important: Even we extends from SelectOneResponseBlock, to avoid conflict we SHOULD re-declare @blockVuexNamespace based getter, state, action, mutation


Reporter: ESLint
Rule: eslint.rules.max-len
Severity: WARN
File: src/components/interaction-designer/block-types/MobilePrimitives_SelectManyResponseBlock.vue L106

This line has a length of 156. Maximum allowed is 140. (max-len)

github-actions · 2021-07-15T23:19:30Z

src/components/interaction-designer/block-types/SmartDevices_LocationResponseBlock.vue

@@ -66,6 +70,8 @@ class SmartDevices_LocationResponseBlock extends mixins(Lang) {
  // @Prop()readonly block!: ILocationResponseBlock
  @Prop() readonly flow!: IFlow

+  showSemanticLabel = false
+
  updateThreshold(value: number) {


Reporter: ESLint
Rule: eslint.rules.@typescript-eslint/explicit-function-return-type
Severity: WARN
File: src/components/interaction-designer/block-types/SmartDevices_LocationResponseBlock.vue L75

Missing return type on function. (@typescript-eslint/explicit-function-return-type)

github-actions · 2021-07-15T23:19:31Z

src/components/interaction-designer/block-types/SmartDevices_LocationResponseBlock.vue

@@ -66,6 +70,8 @@ class SmartDevices_LocationResponseBlock extends mixins(Lang) {
  // @Prop()readonly block!: ILocationResponseBlock
  @Prop() readonly flow!: IFlow

+  showSemanticLabel = false
+
  updateThreshold(value: number) {


Reporter: ESLint
Rule: eslint.rules.@typescript-eslint/explicit-module-boundary-types
Severity: WARN
File: src/components/interaction-designer/block-types/SmartDevices_LocationResponseBlock.vue L75

Missing return type on function. (@typescript-eslint/explicit-module-boundary-types)

github-actions · 2021-07-15T23:19:32Z

src/components/interaction-designer/resource-editors/ResourceEditor.vue

+                  v-if="can(['edit-content', 'send-call-to-records'], true) && !findOrGenerateStubbedVariantOn(resource,{language_id: languageId, content_type: contentType, modes: [mode]}).value"
+                  :recording-key="`${block.uuid}:${languageId}`" />
+
+                <template v-if="!findAudioResourceVariantFor(resource, {language_id: languageId, content_type: contentType, modes: [mode]})">


Reporter: ESLint
Rule: eslint.rules.max-len
Severity: WARN
File: src/components/interaction-designer/resource-editors/ResourceEditor.vue L54

This line has a length of 141. Maximum allowed is 140. (max-len)

github-actions · 2021-07-15T23:19:32Z

src/components/interaction-designer/resource-editors/ResourceEditor.vue

+                    {language_id: languageId, content_type: contentType, modes: [mode]}).value" />
+
+                <phone-recorder
+                  v-if="can(['edit-content', 'send-call-to-records'], true) && !findOrGenerateStubbedVariantOn(resource,{language_id: languageId, content_type: contentType, modes: [mode]}).value"


Reporter: ESLint
Rule: eslint.rules.max-len
Severity: WARN
File: src/components/interaction-designer/resource-editors/ResourceEditor.vue L51

This line has a length of 195. Maximum allowed is 140. (max-len)

github-actions · 2021-07-15T23:19:33Z

src/components/interaction-designer/resource-editors/ResourceEditor.vue

+                :mode="mode"
+                :enable-autogen-button="true || enableAutogenButton" />
+
+              <div v-if="contentType === SupportedContentType.AUDIO">


Reporter: ESLint
Rule: eslint.rules.vue/require-v-for-key
Severity: ERROR
File: src/components/interaction-designer/resource-editors/ResourceEditor.vue L41

Elements in iteration expect to have 'v-bind:key' directives. (vue/require-v-for-key)

github-actions · 2021-07-15T23:19:33Z

src/components/interaction-designer/resource-editors/ResourceEditor.vue

+            <template v-for="contentType in discoverContentTypesFor(mode)">
+              <!-- todo: it's odd that we pass around a ContentType variant rather than a ContentTypeLangMode variant (aka, mode as external arg) -->
+
+              <resource-variant-text-editor


Reporter: ESLint
Rule: eslint.rules.vue/valid-v-for
Severity: ERROR
File: src/components/interaction-designer/resource-editors/ResourceEditor.vue L31

Custom elements in iteration require 'v-bind:key' directives. (vue/valid-v-for)

github-actions · 2021-07-15T23:19:34Z

src/components/interaction-designer/resource-editors/ResourceEditor.vue

+            </header>
+
+            <template v-for="contentType in discoverContentTypesFor(mode)">
+              <!-- todo: it's odd that we pass around a ContentType variant rather than a ContentTypeLangMode variant (aka, mode as external arg) -->


Reporter: ESLint
Rule: eslint.rules.max-len
Severity: WARN
File: src/components/interaction-designer/resource-editors/ResourceEditor.vue L29

This line has a length of 149. Maximum allowed is 140. (max-len)

github-actions · 2021-07-15T23:19:35Z

src/components/interaction-designer/resource-editors/ResourceEditor.vue

+                v-if="iconsMap.get(mode)"
+                :icon="iconsMap.get(mode)"
+                :class="{'custom-icons': iconsMap.get(mode)[0] === 'fac', 'library-icons': iconsMap.get(mode)[0] !== 'fac'}" />
+              <h6 class="ml-1">{{ `flow-builder.${mode.toLowerCase()}-content` | trans }}</h6>


Reporter: ESLint
Rule: eslint.rules.vue/singleline-html-element-content-newline
Severity: WARN
File: src/components/interaction-designer/resource-editors/ResourceEditor.vue L25

Expected 1 line break after opening tag (`<h6>`), but no line breaks found. (vue/singleline-html-element-content-newline)

github-actions · 2021-07-15T23:19:36Z

src/components/interaction-designer/resource-editors/ResourceEditor.vue

+                v-if="iconsMap.get(mode)"
+                :icon="iconsMap.get(mode)"
+                :class="{'custom-icons': iconsMap.get(mode)[0] === 'fac', 'library-icons': iconsMap.get(mode)[0] !== 'fac'}" />
+              <h6 class="ml-1">{{ `flow-builder.${mode.toLowerCase()}-content` | trans }}</h6>


Reporter: ESLint
Rule: eslint.rules.vue/singleline-html-element-content-newline
Severity: WARN
File: src/components/interaction-designer/resource-editors/ResourceEditor.vue L25

Expected 1 line break before closing tag (`</h6>`), but no line breaks found. (vue/singleline-html-element-content-newline)

poojahpatil90 added 7 commits June 30, 2021 11:11

VMO-4138 Title Component

29cc712

VMO-4138 Fixed some issues on title editor

1b0c54d

VMO-4138 Updated Resource editor

d7cd50b

VMO-4138 Overrode primary color of bootstrap

32e4715

VMO-4138 Component for custom SVG Icons

61a8d95

VMO-4138 Updated Set as First Block button

999ec5d

VMO-4138 Updating IVR content design in Resources

b6680b1

poojahpatil90 requested a review from bzabos July 8, 2021 01:20

poojahpatil90 added 3 commits July 8, 2021 12:48

VMO-4138 Localizing the labels

c59f9ac

VMO-4138 Adding icons to Resources

01f9c73

VMO-4138 Adding horizontal divider

01c9a00

github-actions bot reviewed Jul 9, 2021

View reviewed changes

poojahpatil90 added 2 commits July 8, 2021 17:20

VMO-4138 Updating snapshot

7e9a0e7

Merge branch 'master' into VMO-4138-unified-message-block

1e5870a

# Resolved Conflicts: # tests/unit/__snapshots__/storybook.spec.ts.snap

bzabos approved these changes Jul 9, 2021

View reviewed changes

poojahpatil90 added 2 commits July 10, 2021 13:24

VMO-4138 Separating title and block code components

0abf890

VMO-4138 Adding semantic label

5d8f9c0

poojahpatil90 added 4 commits July 11, 2021 13:23

VMO-4138 Fixed review comments

e16defa

VMO-4138 A few UX improvements

17541a6

Merge branch 'master' into VMO-4138-unified-message-block

5dd86ff

VMO-4138 Updated icons to be added to font-awesome library

99725c8

github-actions bot reviewed Jul 13, 2021

View reviewed changes

github-actions bot reviewed Jul 15, 2021

View reviewed changes

VMO-4138 Updating snapshot

210abde

yeboaasare approved these changes Jul 16, 2021

View reviewed changes

poojahpatil90 merged commit 34d7395 into master Jul 16, 2021

poojahpatil90 deleted the VMO-4138-unified-message-block branch July 16, 2021 23:31

VMO-4138 Unified Message Block #109

VMO-4138 Unified Message Block #109

Conversation

poojahpatil90 commented Jul 8, 2021 • edited Loading

github-actions bot Jul 9, 2021

Choose a reason for hiding this comment

github-actions bot Jul 9, 2021

Choose a reason for hiding this comment

bzabos left a comment

Choose a reason for hiding this comment

bzabos commented Jul 9, 2021

poojahpatil90 commented Jul 9, 2021

poojahpatil90 commented Jul 11, 2021

poojahpatil90 commented Jul 11, 2021 • edited Loading

github-actions bot Jul 13, 2021

Choose a reason for hiding this comment

github-actions bot Jul 13, 2021

Choose a reason for hiding this comment

github-actions bot Jul 13, 2021

Choose a reason for hiding this comment

github-actions bot Jul 13, 2021

Choose a reason for hiding this comment

github-actions bot Jul 15, 2021

Choose a reason for hiding this comment

github-actions bot Jul 15, 2021

Choose a reason for hiding this comment

github-actions bot Jul 15, 2021

Choose a reason for hiding this comment

github-actions bot Jul 15, 2021

Choose a reason for hiding this comment

github-actions bot Jul 15, 2021

Choose a reason for hiding this comment

github-actions bot Jul 15, 2021

Choose a reason for hiding this comment

github-actions bot Jul 15, 2021

Choose a reason for hiding this comment

github-actions bot Jul 15, 2021

Choose a reason for hiding this comment

github-actions bot Jul 15, 2021

Choose a reason for hiding this comment

github-actions bot Jul 15, 2021

Choose a reason for hiding this comment

github-actions bot Jul 15, 2021

Choose a reason for hiding this comment

github-actions bot Jul 15, 2021

Choose a reason for hiding this comment

github-actions bot Jul 15, 2021

Choose a reason for hiding this comment

github-actions bot Jul 15, 2021

Choose a reason for hiding this comment

github-actions bot Jul 15, 2021

Choose a reason for hiding this comment

github-actions bot Jul 15, 2021

Choose a reason for hiding this comment

github-actions bot Jul 15, 2021

Choose a reason for hiding this comment

github-actions bot Jul 15, 2021

Choose a reason for hiding this comment

github-actions bot Jul 15, 2021

Choose a reason for hiding this comment

github-actions bot Jul 15, 2021

Choose a reason for hiding this comment

github-actions bot Jul 15, 2021

Choose a reason for hiding this comment

github-actions bot Jul 15, 2021

Choose a reason for hiding this comment

github-actions bot Jul 15, 2021

Choose a reason for hiding this comment

github-actions bot Jul 15, 2021

Choose a reason for hiding this comment

github-actions bot Jul 15, 2021

Choose a reason for hiding this comment

github-actions bot Jul 15, 2021

Choose a reason for hiding this comment

poojahpatil90 commented Jul 8, 2021 •

edited

Loading

poojahpatil90 commented Jul 11, 2021 •

edited

Loading