-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Network message #883
Network message #883
Conversation
I don't really like how inside Alternate options being:
|
850638b
to
120c39c
Compare
120c39c
to
e0848f9
Compare
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
bee9adf
to
c16f11b
Compare
This comment was marked as outdated.
This comment was marked as outdated.
c16f11b
to
db36256
Compare
72e20fe
to
df470e8
Compare
This comment was marked as outdated.
This comment was marked as outdated.
All current It's assumed subsequent tests will cover the traversal of graphs, so the actual sort will be tested implicitly. However, we may wish to remove indexable edge access in future, as the sort will lead to confusion?? |
This comment was marked as outdated.
This comment was marked as outdated.
0a27a93
to
86dfeaf
Compare
This comment was marked as outdated.
This comment was marked as outdated.
ID currently exists as an automatically added Vertex variable. But it's not used for anything? Whereas other libs/pete use ID inplace where we currently use index. |
9e1bfb7
to
25d1f7b
Compare
91b70fa
to
d13d177
Compare
7bba68d
to
1812fc3
Compare
The HostAPI auto sync could be improved. If the user calls
The graph will be sync'd, prior to them accessing the CUDA buffers (ignoring the fact this doesn't mark the graph for rebuild). This however would require some proper internal tracking to ensure it persists to the end of the host fn. |
1812fc3
to
ed3651d
Compare
I don't think it validates that edge src/dest are within range of valid vertex indices. |
c95100f
to
926e756
Compare
926e756
to
765ad80
Compare
765ad80
to
3eac0b9
Compare
Currently it exposes no additional functionality.
Directed graphs can be defined on the Host and accessed and traversed on device (edges in/out of a given vertex). Vertices and Edges are currently referred to by their index, although Vertices have a mandatory ID property. The ID property is currently used, it would be possible to switch traversal to use IDs however it adds an extra layer of indirection to all accesses so has not currently been done. Graphs can be exported/imported to a JSON format compatible with d3.js. Tests added for all current functionality. Also fixed a few GLM_ON build issues, likely a side effect of refactors prior to release.
HostAPI::getCUDAStream() HostEnvironmentDirectedGraph::getCUDABuffers()
FRE project requires this
…w places. Probably a bad merge.
Not sure if this change will impact SEATBELTS=0 performance.
Deprecated by #1089, to avoid breaking FRE dependency during development before the feature is merged into |
Some of the original ideas here.
Stage 1 - Static environment graph
ADVANCED_API
method to HostAPI to expose CUDA buffers/stream.Do we want host traverse?(Not immediately)(internal) Proper backing graph data structure/sortStage 2 - Messages for the graph