Improvements to Telemetry #1252
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ptheywood
reviewed
Nov 20, 2024
ptheywood
reviewed
Nov 20, 2024
ptheywood
previously approved these changes
Nov 21, 2024
ptheywood
force-pushed
the
Telemetry-Python
branch
from
a4e5dac to
4516103
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Closes #1212
Improves Telemetry by generating unique User Ids rather than using the cmake build ID. This will allow us to track Python users which are currently lumped into a single user per wheel.
There is no test for this but it can be tested by enabling
FLAMEGPU_TELEMETRY_TEST_MODE.Note that the User Id will be salted and hashed by Telemetry deck.