Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

<fix>(consensus,auth): fix add sealer bug when sdk connect observer to be added. #807

Merged
merged 1 commit into from
Jul 21, 2023

Conversation

kyonRay
Copy link
Member

@kyonRay kyonRay commented Jul 21, 2023

No description provided.

@sonarcloud
Copy link

sonarcloud bot commented Jul 21, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@codecov
Copy link

codecov bot commented Jul 21, 2023

Codecov Report

Patch coverage: 29.16% and project coverage change: -0.03 ⚠️

Comparison is base (7b291cc) 32.30% compared to head (7add590) 32.28%.

❗ Current head 7add590 differs from pull request most recent head 23a4432. Consider uploading reports for the commit 23a4432 to get more accurate results

Additional details and impacted files
@@                 Coverage Diff                 @@
##             release-3.2.3     #807      +/-   ##
===================================================
- Coverage            32.30%   32.28%   -0.03%     
+ Complexity            1504     1503       -1     
===================================================
  Files                  379      379              
  Lines                13729    13739      +10     
  Branches              1542     1546       +4     
===================================================
  Hits                  4435     4435              
- Misses                8907     8915       +8     
- Partials               387      389       +2     
Impacted Files Coverage Δ
...ntract/precompiled/consensus/ConsensusService.java 14.54% <0.00%> (-1.46%) ⬇️
...bcos/sdk/v3/contract/auth/manager/AuthManager.java 29.92% <58.33%> (-0.20%) ⬇️

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@kyonRay kyonRay merged commit 0d2f2fd into FISCO-BCOS:release-3.2.3 Jul 21, 2023
9 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants