Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

<fix> FISCO-BCOS/go-sdk#260 #268

Merged
merged 5 commits into from
Mar 7, 2024
Merged

Conversation

Keyon11
Copy link
Contributor

@Keyon11 Keyon11 commented Mar 4, 2024

partially fix #260 , should update go.mod use the lastest version bcos-c-sdk after merge

Copy link

codecov bot commented Mar 6, 2024

Codecov Report

Attention: Patch coverage is 49.29577% with 36 lines in your changes are missing coverage. Please review.

Project coverage is 42.75%. Comparing base (aa7c485) to head (a1392e9).

Files Patch % Lines
v3/client/connection.go 49.29% 27 Missing and 9 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #268      +/-   ##
==========================================
- Coverage   43.80%   42.75%   -1.06%     
==========================================
  Files           5        5              
  Lines         678      676       -2     
==========================================
- Hits          297      289       -8     
- Misses        310      315       +5     
- Partials       71       72       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@bxq2011hust bxq2011hust left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bxq2011hust bxq2011hust merged commit 6a6596c into FISCO-BCOS:master Mar 7, 2024
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

go-sdk空跑cpu200
2 participants