-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test branch changes pre-event and changes during the event #9
Conversation
…light shooting ready for testing
… stop shooter raise arm
Lights subsystem addition
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I left a bunch of comments - most were questions, but I think lights will need a change after we index a note out of the robot. I think there is an arm encoder offset that might not be a problem - but it's hard coded and also in constants - so confusing.
approving because I don't see anything bad enough to cause a major problem as far as I can tell
SetScoringPosition
command. Can take in either the newScoringPosition
data type (a record that represents arm angle and shooter speed) or a function that supplies aScoringPosition