Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft: Support for unix pattern in packages #88

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

LSerranoPEReN
Copy link

Purpose of This Pull Request

Please check the relevant option by placing an "X" inside the brackets:

  • Documentation update
  • Bug fix
  • New feature
  • Other (please explain):

Overview of Changes

This MR adds Unix pattern support for ignored packages.

I have a very concrete case where I use Nvidia deep learning packages in a project, that come with a proprietary license that I know is compatible with my project, so each of the packages is marked as ignored in my pyproject file.

Since all Nvidia packages in my project have the same pattern (nvidia-cublas-cu11, nvidia-cuda-cupti-cu11, etc.), I wanted to compact the ignore-package section a bit. This MR enables to declare nvidia-*-cu11 as ignored, using Unix style patterns and fnmatchcase function.

Reviewer Focus

This MR is a draft, but I tested that the feature was working in my project.
I wanted to know if this was a good idea or not before maybe adding this feature to other sections, like maybe fail-packages, and adding tests and documentation.

Additional Notes

I'm using Unix patterns instead of regexes for the sake of simplicity, but I am open to use regexes instead if needed.

@FredHappyface
Copy link
Member

Hi thanks for this, and apologies for the delay in reviewing. I completely agree that this is an important usecase and would be happy to merge. I've just merged one of my branches in to (with hindsight it may have been beneficial to merge this branch first)

I'm happy to merge and resolve any conflicts if you are?

I'll probably write some tests when I get around to it too but most likely going to be in the new year now :)

@LSerranoPEReN
Copy link
Author

Hi,
Thank you for taking the time to look at my PR.

I'm happy to merge and resolve any conflicts if you are?

I'll probably write some tests when I get around to it too but most likely going to be in the new year now :)

I have no problem with that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants