Draft: Support for unix pattern in packages #88
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of This Pull Request
Please check the relevant option by placing an "X" inside the brackets:
Overview of Changes
This MR adds Unix pattern support for ignored packages.
I have a very concrete case where I use Nvidia deep learning packages in a project, that come with a proprietary license that I know is compatible with my project, so each of the packages is marked as ignored in my pyproject file.
Since all Nvidia packages in my project have the same pattern (
nvidia-cublas-cu11
,nvidia-cuda-cupti-cu11
, etc.), I wanted to compact the ignore-package section a bit. This MR enables to declarenvidia-*-cu11
as ignored, using Unix style patterns andfnmatchcase
function.Reviewer Focus
This MR is a draft, but I tested that the feature was working in my project.
I wanted to know if this was a good idea or not before maybe adding this feature to other sections, like maybe fail-packages, and adding tests and documentation.
Additional Notes
I'm using Unix patterns instead of regexes for the sake of simplicity, but I am open to use regexes instead if needed.