Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added EncounterFlat and ConditionFlat examples #260

Merged
merged 1 commit into from
Oct 11, 2024

Conversation

bashir2
Copy link
Collaborator

@bashir2 bashir2 commented Sep 7, 2024

Added two examples from Open Health Stack flattening ViewDefinitions (specifically from here).
Note that the publisher tool fails on this PR with an NPE as discussed/fixed in this other PR.

@johngrimes
Copy link
Collaborator

Thanks @bashir2!

This looks fine to me, but I feel like we should wait until the the fix makes it into the IG publisher before merging.

Otherwise I don't know how we can continue to build our IG successfully...

@bashir2
Copy link
Collaborator Author

bashir2 commented Sep 10, 2024

Thanks @bashir2!

This looks fine to me, but I feel like we should wait until the the fix makes it into the IG publisher before merging.

Otherwise I don't know how we can continue to build our IG successfully...

Thanks @johngrimes. Yeah that's correct; I won't merge this until my fix to the publisher tool is merged and released.

@bashir2
Copy link
Collaborator Author

bashir2 commented Oct 9, 2024

@johngrimes I think the publisher tool has been finally fixed/released and I think we can merge this PR now (the publisher tool does not produce the NPE on this change anymore). I know you are in the process of generating a release candidate for SQL-on-FHIR IG, so please merge this when the time is right.

@johngrimes johngrimes merged commit ecffb3d into FHIR:master Oct 11, 2024
@bashir2 bashir2 deleted the examples branch October 24, 2024 21:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants