-
-
Notifications
You must be signed in to change notification settings - Fork 263
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update GitHub workflow to fix the broken build #510
Conversation
Not sure why this pull request didn't trigger a build, but I already tested it in my fork in this github action run: https://github.com/YasharF/mailchecker/actions/runs/12817070395 |
c7ef94d
to
7e2dd65
Compare
Test run of this workflow https://github.com/YasharF/mailchecker/actions/runs/13033640026/workflow |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you very much for this PR.
I have a little question, otherwise it's perfect
Update: removed the matrix run, and set the workflow to run with nodejs 22.x. Here is a test run of the workflow |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice, thanks you
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot for your first, and very valuable contribution 🎉
Updated the workflow to run with the current LTS versions of Node.js. The list in the matrix will need to be updated as the LTS versions change. April 2025 is probably a good time to revisit this list as node 18 will enter EoL and they are supposed to start releasing Node 24.Updated the workflow to latest LTS versions of Node.js aka 22.x.