Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update GitHub workflow to fix the broken build #510

Merged
merged 3 commits into from
Jan 31, 2025

Conversation

YasharF
Copy link
Contributor

@YasharF YasharF commented Jan 16, 2025

  1. Moving from docker-practice to the official docker action. docker-practice isn’t as well maintained and ubuntu-24.04 has compatibility issue with it. Ref: Error - cat: /etc/docker/daemon.json: No such file or directory - ubuntu-24.04 actions/runner-images#11408 and cat: /etc/docker/daemon.json: No such file or directory actions/runner-images#10697
  2. Updated the workflow to run with the current LTS versions of Node.js. The list in the matrix will need to be updated as the LTS versions change. April 2025 is probably a good time to revisit this list as node 18 will enter EoL and they are supposed to start releasing Node 24. Updated the workflow to latest LTS versions of Node.js aka 22.x.
  3. Updated other configs to use the latest versions
  4. Updated the workflow to build and run the tests after installing the package. This can help identify pull requests or repo changes that are breaking changes. It can also help with enabling updates of dependencies using dependabot in the future.
  5. Removed extra comments that probably came with the original yaml template.

@YasharF YasharF changed the title Update GitHub workflow to fix build issues Update GitHub workflow to fix the broken build Jan 16, 2025
@YasharF
Copy link
Contributor Author

YasharF commented Jan 16, 2025

Not sure why this pull request didn't trigger a build, but I already tested it in my fork in this github action run: https://github.com/YasharF/mailchecker/actions/runs/12817070395

@YasharF
Copy link
Contributor Author

YasharF commented Jan 29, 2025

Copy link
Collaborator

@lyrixx lyrixx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much for this PR.

I have a little question, otherwise it's perfect

.github/workflows/main.yml Outdated Show resolved Hide resolved
@YasharF
Copy link
Contributor Author

YasharF commented Jan 30, 2025

Update: removed the matrix run, and set the workflow to run with nodejs 22.x. Here is a test run of the workflow
https://github.com/YasharF/mailchecker/actions/runs/13054178384/workflow

Copy link
Collaborator

@lyrixx lyrixx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice, thanks you

.github/workflows/main.yml Outdated Show resolved Hide resolved
Copy link
Collaborator

@lyrixx lyrixx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for your first, and very valuable contribution 🎉

@lyrixx lyrixx merged commit 4ad9e1a into FGRibreau:master Jan 31, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants