Introduce MixedMesh + handle restrictions on MixedMesh #264
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Mar 27, 2024
ksagiyam
force-pushed
the
ksagiyam/introduce_mixed_map
branch
from
e07f9fa to
d574909
Compare
ksagiyam
force-pushed
the
ksagiyam/introduce_mixed_map
branch
8 times, most recently
from
e66d41d to
d3e72fb
Compare
ksagiyam
commented
Aug 21, 2024
ufl/exproperators.py
Outdated
|
|
||
| def _restrict(self, side): | ||
| """Restrict.""" | ||
| if side == "+": | ||
| return PositiveRestricted(self) | ||
| if side == "-": | ||
| return NegativeRestricted(self) | ||
| if side == "|": | ||
| return SingleValueRestricted(self) |
ksagiyam
changed the title
ksagiyam
force-pushed
the
ksagiyam/introduce_mixed_map
branch
2 times, most recently
from
23696eb to
ae55b3b
Compare
ksagiyam
force-pushed
the
ksagiyam/introduce_mixed_map
branch
from
ae55b3b to
4ced3a7
Compare
ksagiyam
force-pushed
the
ksagiyam/introduce_mixed_map
branch
5 times, most recently
from
7e4dd44 to
ef8fd99
Compare
jorgensd
reviewed
Jan 13, 2025
| restriction = t._side | ||
| t, = t.ufl_operands | ||
| elif t._ufl_terminal_modifiers_: | ||
| raise ValueError("Missing handler for terminal modifier type %s, object is %s." % (type(t), repr(t))) |
There was a problem hiding this comment.
Is there a reason for not using f-strings here?
There was a problem hiding this comment.
No. I will fix it when I tidy this up. Thanks.
jorgensd
reviewed
Jan 13, 2025
| # Only split mixed coefficients | ||
| return o | ||
| # Reference value expected | ||
| assert reference_value |
There was a problem hiding this comment.
Should this throw a run-time error instead of an assertion, as something has clearly gone wrong if you have gotten here without t being a Coefficient and ReferenceValue.
ksagiyam
force-pushed
the
ksagiyam/introduce_mixed_map
branch
from
24006ee to
988189f
Compare
Co-authored-by: Jørgen Schartum Dokken <[email protected]>
Co-authored-by: Jørgen Schartum Dokken <[email protected]>
ksagiyam
force-pushed
the
ksagiyam/introduce_mixed_map
branch
from
988189f to
36559fc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Need rebasing.