FileManagement: Throw a warning if /proc can't be opened
#4357
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We use this for ProcFD collision checking. Give a warning if it can't be opened, also not doing the additional work when it fails. This isn't likely to occur unless someone messes up their rootfs mounts.
neobrain
reviewed
Feb 13, 2025
| ProcFSDev = Buffer.st_dev; | ||
| } | ||
| } else { | ||
| LogMan::Msg::EFmt("Couldn't open `/proc`. Is ProcFS mounted? FEX won't be able to track FD conflicts"); |
There was a problem hiding this comment.
If this indicates invalid setup, wouldn't a fatal error be more appropriate?
There was a problem hiding this comment.
It's not necessarily fatal if people know what they're doing. The user is already in a semi-broken Linux state if procfs isn't mounted, so they're already "colouring outside of the lines".
neobrain
approved these changes
Feb 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We use this for ProcFD collision checking. Give a warning if it can't be opened, also not doing the additional work when it fails.
This isn't likely to occur unless someone messes up their rootfs mounts.