Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JIT: Avoid OOB EC bitmap checks in ExitFunction #4269

Merged
merged 1 commit into from
Jan 14, 2025
Merged

JIT: Avoid OOB EC bitmap checks in ExitFunction #4269

merged 1 commit into from
Jan 14, 2025

Conversation

bylaws
Copy link
Collaborator

@bylaws bylaws commented Jan 12, 2025

Multiblock can generate such not-taken ExitFunction calls when enabled

Sonicadvance1
Sonicadvance1 approved these changes Jan 12, 2025
View reviewed changes
Copy link
Member

@Sonicadvance1 Sonicadvance1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting that RtlIsEcCode doesn't handle non-canonical addresses for you, but sure.

@alyssarosenzweig alyssarosenzweig merged commit 8c02bd4 into FEX-Emu:main Jan 14, 2025
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alyssarosenzweig alyssarosenzweig alyssarosenzweig approved these changes

@Sonicadvance1 Sonicadvance1 Sonicadvance1 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bylaws @Sonicadvance1 @alyssarosenzweig