cmake: Adds some missing STATIC qualifiers #4258
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Noticed this as I was scrolling through some cmake. Usually this doesn't matter as we declare `BUILD_SHARED_LIBS` as False/Off, but this can technically be overridden even when we don't want to. Updates the two definitions of `add_library` that was missing the static qualifier to ensure they generate the code we want.
lioncash
approved these changes
Jan 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Noticed this as I was scrolling through some cmake. Usually this doesn't matter as we declare
BUILD_SHARED_LIBSas False/Off, but this can technically be overridden even when we don't want to.Updates the two definitions of
add_librarythat was missing the static qualifier to ensure they generate the code we want.