Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvements to the Dockerfile #3376

Merged
merged 1 commit into from
Jan 19, 2024
Merged

Improvements to the Dockerfile #3376

merged 1 commit into from
Jan 19, 2024

Conversation

Guztaver
Copy link
Contributor

I added the pkg-config that is missing in the Dockerfile, and make the git clone the repository direct from the image, so the user don't need to clone it manually and after that pulls inside the Dockerfile!

If the git change is too much, tell me that I remove it and keep only the dependecies update, because without it, it's not compiling at all.

I added the `pkg-config` that is missing in the Dockerfile, and make the git clone the repository direct from the image, so the user don't need to clone it manually and after that pulls inside the Dockerfile!
@Guztaver
Copy link
Contributor Author

Guztaver commented Jan 19, 2024

I was thinking about adding something to the git clone section if this change goes forward. (I didn't add it because I don't know if it will be included)

The changes are basicly adds cache to the git, to make compile times less longers when used mutiple times in a row:

RUN --mount=type=cache,target=/opt/FEX \
  git clone --recurse-submodules https://github.com/FEX-Emu/FEX.git /opt/FEX; \
  cd /opt/FEX \ 
  git pull \

@Sonicadvance1
Copy link
Member

Seems reasonable to me. I'm surprised this docker file works at all since it is random user's whims to implement it.

@Sonicadvance1 Sonicadvance1 merged commit 1627331 into FEX-Emu:main Jan 19, 2024
10 checks passed
@Guztaver Guztaver deleted the patch-1 branch January 19, 2024 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants