Arm64: Removes a vtable indirection in syscalls #3327
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will be useful to remove an indirection.
We can safely call virtual functions through the JIT with a little bit of work. FEX's JIT has quite a few steps before it gets to a syscall handler. Before this commit: JIT->static HandleSyscall->SyscallHandler::HandleSyscall->SyscallHandler After this commit: JIT->SyscallHandler::HandleSyscall->SyscallHandler A bit hard to notice this when this interface can spin at 67-million calls per second though.
Sonicadvance1
force-pushed
the
remove_syscall_indirection
branch
from
146d06a to
266f7fe
Compare
alyssarosenzweig
approved these changes
Jan 3, 2024
| @@ -17,24 +17,52 @@ class MemberFunctionToPointerCast final { | |||
| public: | |||
| MemberFunctionToPointerCast(PointerToMemberType Function) { | |||
There was a problem hiding this comment.
This seems to lose the assertions. Is that intended?
There was a problem hiding this comment.
Intended, the asserts get moved to the accessor functions GetConvertedPointer and GetVTableOffset instead.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We can safely call virtual functions through the JIT with a little bit
of work.
FEX's JIT has quite a few steps before it gets to a syscall handler.
Before this commit:
JIT->static HandleSyscall->SyscallHandler::HandleSyscall->SyscallHandler
After this commit:
JIT->SyscallHandler::HandleSyscall->SyscallHandler
A bit hard to notice this when this interface can spin at 67-million
calls per second though.