Skip to content

Commit

Permalink
OpcodeDispatcher: drop result masking for shifts
Browse files Browse the repository at this point in the history
flag calcs are fine with upper garbage.

Signed-off-by: Alyssa Rosenzweig <[email protected]>
  • Loading branch information
alyssarosenzweig committed Mar 29, 2024
1 parent 7da1066 commit c9f972a
Showing 1 changed file with 0 additions and 7 deletions.
7 changes: 0 additions & 7 deletions FEXCore/Source/Interface/Core/OpcodeDispatcher.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -1579,10 +1579,6 @@ void OpDispatchBuilder::SHLOp(OpcodeArgs) {
OrderedNode *Result = _Lshl(Size == 64 ? OpSize::i64Bit : OpSize::i32Bit, Dest, Src);
StoreResult(GPRClass, Op, Result, -1);

if (Size < 32) {
Result = _Bfe(OpSize::i32Bit, Size, 0, Result);
}

if constexpr (SHL1Bit) {
GenerateFlags_ShiftLeftImmediate(Op, Result, Dest, 1);
}
Expand Down Expand Up @@ -1789,9 +1785,6 @@ void OpDispatchBuilder::SHRDOp(OpcodeArgs) {

StoreResult(GPRClass, Op, Res, -1);

if (Size != 64) {
Res = _Bfe(OpSize::i64Bit, Size, 0, Res);
}
GenerateFlags_ShiftRight(Op, Res, Dest, Shift);
}

Expand Down

0 comments on commit c9f972a

Please sign in to comment.