Merge pull request #4355 from Sonicadvance1/move_instead_of_copy

Fixes a couple locations where is variable is copied when it could be moved
FEX-Emu · Feb 13, 2025 · b76a296 · b76a296
2 parents 42b0fbd + 917cbba
commit b76a296
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/Source/Tools/LinuxEmulation/LinuxSyscalls/Syscalls.cpp b/Source/Tools/LinuxEmulation/LinuxSyscalls/Syscalls.cpp
@@ -938,7 +938,7 @@ SyscallHandler::GenerateMap(const std::string_view& GuestBinaryFile, const std::
     return {};
   }
 
-  const auto GuestSourceFile = fextl::fmt::format("{}/{}.src", FexSrcPath, GuestBinaryFileId);
+  auto GuestSourceFile = fextl::fmt::format("{}/{}.src", FexSrcPath, GuestBinaryFileId);
 
   struct stat GuestSourceFileStat;
 
@@ -1061,7 +1061,7 @@ SyscallHandler::GenerateMap(const std::string_view& GuestBinaryFile, const std::
 
     auto rv = fextl::make_unique<FEXCore::HLE::SourcecodeMap>();
 
-    rv->SourceFile = GuestSourceFile;
+    rv->SourceFile = std::move(GuestSourceFile);
 
     auto EndSymbol = [&] {
       if (LastSymbolOffset) {

diff --git a/Source/Tools/pidof/pidof.cpp b/Source/Tools/pidof/pidof.cpp
@@ -155,7 +155,7 @@ int main(int argc, char** argv) {
     PIDs.emplace_back(PIDInfo {
       .pid = pid,
       .cmdline = CMDLineData.str(),
-      .exe_link = exe_link,
+      .exe_link = std::move(exe_link),
       .State = State,
     });
   }