IR: do not clobber flags in caspair

slightly worse in the emulated case, I don't really care Signed-off-by: Alyssa Rosenzweig <[email protected]>
FEX-Emu · Mar 29, 2024 · 0cf4ee5 · 0cf4ee5
1 parent 58a2441
commit 0cf4ee5
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/FEXCore/Source/Interface/Core/JIT/Arm64/AtomicOps.cpp b/FEXCore/Source/Interface/Core/JIT/Arm64/AtomicOps.cpp
@@ -37,9 +37,10 @@ DEF_OP(CASPair) {
     Bind(&LoopTop);
 
     ldaxp(EmitSize, TMP2, TMP3, MemSrc);
-    cmp(EmitSize, TMP2, Expected.first);
-    ccmp(EmitSize, TMP3, Expected.second, ARMEmitter::StatusFlags::None, ARMEmitter::Condition::CC_EQ);
-    b(ARMEmitter::Condition::CC_NE, &LoopNotExpected);
+    eor(EmitSize, TMP1, TMP2, Expected.first);
+    eor(EmitSize, TMP4, TMP3, Expected.second);
+    orr(EmitSize, TMP1, TMP1, TMP4);
+    cbnz(EmitSize, TMP1, &LoopNotExpected);
     stlxp(EmitSize, TMP2, Desired.first, Desired.second, MemSrc);
     cbnz(EmitSize, TMP2, &LoopTop);
     mov(EmitSize, Dst.first, Expected.first);

diff --git a/FEXCore/Source/Interface/IR/IR.json b/FEXCore/Source/Interface/IR/IR.json
@@ -642,7 +642,6 @@
                 ],
         "HasDest": true,
         "DestSize": "Size",
-        "ImplicitFlagClobber": true,
         "NumElements": "2",
         "EmitValidation": [
           "Size == FEXCore::IR::OpSize::i64Bit || Size == FEXCore::IR::OpSize::i128Bit"