Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft: remove parms library #582

Closed
wants to merge 17 commits into from
Closed

Conversation

JanStreffing
Copy link
Collaborator

@JanStreffing JanStreffing commented Mar 25, 2024

oce_ale needs work still. Some things from #ifdef parms seemingly are required outside of it.

patrickscholz and others added 17 commits October 4, 2021 12:12
Fix bug when making restart with cavity from partial cell off --> partial cell on
@koldunovn you were right regarding the line splitting
Update tests
Actions are not triggered for whatever reason, try again.
set more recent compilers and mpi configuration to bsc environment
fix KPP bug discovered by Dima. Affects results, so tests are changed…
bug fix in update_atm_forcing. press_air array was accessed even if n…
gamma0, gamma1 & gamma2 were used instead gamma0_tra, gamma1_tra & gamma2_tra in diff_part_bh
gamma0, gamma1 & gamma2 were used instead gamma0_tra, gamma1_tra & gamma2_tra in diff_part_bh
@JanStreffing JanStreffing added this to the FESOM 2.6 milestone Mar 25, 2024
@JanStreffing JanStreffing linked an issue Mar 25, 2024 that may be closed by this pull request
@JanStreffing JanStreffing marked this pull request as draft March 25, 2024 12:41
@JanStreffing JanStreffing changed the base branch from master to refactoring June 10, 2024 14:40
@JanStreffing
Copy link
Collaborator Author

Yeah no, we are not merging this one. This has to be redone based on refactoring. I had accidentally done it based on master.

@JanStreffing JanStreffing deleted the 569-remove-parms-library branch August 15, 2024 12:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove parms library
5 participants