The great cmake refactoring #515
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Wonderful and timely, will test it and merge it ASAP. |
…insic module ISO_FORTRAN_ENV is incompatible with option -fdefault-real-8
wdeconinck
force-pushed
the
feature/cmake-improvements
branch
2 times, most recently
from
c2d6261
to
4dca53f
Compare
wdeconinck
force-pushed
the
feature/cmake-improvements
branch
from
4dca53f
to
fd0d6ca
Compare
|
I have rebased this branch on latest refactoring as of November 2, 2023. |
This was referenced Nov 29, 2023
JanStreffing
added
leave it for the end
and removed
help wanted
|
We decided to first merge #526 and then seen what remains of this MR, as many of the changes made here will already come into refactoring from production_DE. |
|
I will make a new merge request from a branch that lies in a repo that we can commit to. |
|
Superseded by: #621 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@sebastianbeyer @suvarchal @dsidoren
Here is the promised branch with CMake refactoring.
A few things this now enables
find_package(fesom)Rename BUILD_FESOM_AS_LIBRARY to ENABLE_IFS_INTERFACE. Fesom can always build as library and have a driver executable for the library. Remaining TODO is however a run-time configuration switch to use the IFS-interface or internally provided forcings from file, for this to be working as a single binary.
After this is merged in, it will be easy to merge the multio-climate-dt branch which I have refactored with similar changes before. The changes on this branch make multio completely optional, so it can be merged in the main refactoring branch.