Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix that ensures we dont check for salinity <= 3 inside ice shelf #494

Merged
merged 1 commit into from
Sep 6, 2023
Merged

fix that ensures we dont check for salinity <= 3 inside ice shelf #494

merged 1 commit into from
Sep 6, 2023

Conversation

JanStreffing
Copy link
Collaborator

Since we made sure that the salinity threshold is consistently at 3 PSU everywhere, we can no longer check for salt blowup in the layers above the cavity, where salinity is = 0

@JanStreffing JanStreffing added the bug Something isn't working label Sep 6, 2023
@JanStreffing JanStreffing merged commit 5a4ee3f into refactoring Sep 6, 2023
4 checks passed
@JanStreffing JanStreffing deleted the refactoring_cavity_salt_hotfix branch August 15, 2024 12:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@patrickscholz patrickscholz patrickscholz approved these changes

@dsidoren dsidoren Awaiting requested review from dsidoren

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JanStreffing @patrickscholz