Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove unnecessary / in raw restarts esultPath… #492

Merged
merged 5 commits into from
Mar 12, 2024

Conversation

suvarchal
Copy link
Collaborator

@suvarchal suvarchal commented Aug 27, 2023

remove unnecessary / in io_restart.F90 for raw restarts that forces us to use ResultPath… in the namelist.config, otherwise uisng ResultPath="" will crash at restart. this is not caught by the CI

  1. test in CI uses a particular ResultPath
  2. CI does not test restarts explicitly as restart lengths default to 1y and run length in CI is 1 day.

… in the namelist.config, otherwise suing ResultPath= will crash at restart.
@suvarchal suvarchal marked this pull request as ready for review August 27, 2023 00:55
@JanStreffing JanStreffing added this to the FESOM 2.6 milestone Feb 28, 2024
@JanStreffing JanStreffing merged commit 8f7aa22 into refactoring Mar 12, 2024
4 checks passed
@JanStreffing JanStreffing deleted the raw_restart_minor_fix branch August 15, 2024 12:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants