Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/2.1 awiesm 2.1 async icebergs #363

Open
wants to merge 7 commits into
base: 2.1-awiesm-2.1
Choose a base branch
from

Conversation

ackerlar
Copy link
Collaborator

@ackerlar ackerlar commented Aug 3, 2022

I removed the if clause for reading in the iceberg related namelist section in namelist.config. This enables to run icebergs also when compiled with ASYNC_ICEBERS=OFF. I also adapted the default nemlist.config.

@mandresm
Copy link
Collaborator

mandresm commented Aug 4, 2022

Looks good to me, @pgierz , do you agree?

@pgierz
Copy link
Member

pgierz commented Aug 4, 2022

The default cmake list should have use icebergs off.

@ackerlar
Copy link
Collaborator Author

ackerlar commented Aug 5, 2022

It does. I only changed the iceberg related code in a way that icebergs can be run in a non-asynchronous way if ASYNC_ICEBERGS is OFF.

@pgierz
Copy link
Member

pgierz commented Aug 5, 2022

Sorry, I meant FESOM_COUPLED. I just fixed that; so, should be good to go. Green light from my side :-)

@pgierz
Copy link
Member

pgierz commented Aug 5, 2022

OK sorry, red light: it looks like there are still somehow gfortran bugs :-(

51 |         call get_iceberg_nodes_for_element(mesh, localelement, ib_nods_in_ib_elem, num_ib_nods_in_ib_elem)
[187](https://github.com/FESOM/fesom2/runs/7688905736?check_suite_focus=true#step:4:188)
      |                                          1
[188](https://github.com/FESOM/fesom2/runs/7688905736?check_suite_focus=true#step:4:189)
Error: Explicit interface required for 'get_iceberg_nodes_for_element' at (1): target argument

@ackerlar
Copy link
Collaborator Author

ackerlar commented Aug 5, 2022

Okay, I thought I did it with this commit here https://github.com/FESOM/fesom2/pull/363/commits/e1238a5b6888ae265c5f1bab8c5c07ff7be67ba7
But thanks! :)

@pgierz
Copy link
Member

pgierz commented Aug 5, 2022

Looks like it got changed back in fe0a21e

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants