-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix nexus parsing for NOMAD #304
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 8701886089Details
💛 - Coveralls |
sanbrock
approved these changes
Apr 2, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
domna
force-pushed
the
fix-nexus-parsing
branch
from
April 10, 2024 16:34
8809fa2
to
117bdc3
Compare
sanbrock
approved these changes
Apr 16, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See related issue https://gitlab.mpcdf.mpg.de/nomad-lab/nomad-FAIR/-/merge_requests/1731
lru_cache
always returns the same object if it has been cached already. If this object is altered, the altered object gets returned for subsequent calls of the lru_cached function. See this stackoverflow question for more information: https://stackoverflow.com/questions/54909357/how-to-get-functools-lru-cache-to-return-new-instances. I simply avoid this now by making a copy after the function call. Maybe we'd need to investigate for other objects of this function call and/or in other places if we have the same problem thereget_nxdl_attr_doc
function which added attribute nodes twice. This was due to the fact that all attributes which are part of the inheritance chain were added instead of only the lowest child. Maybe this problem also exists for fields.I made some remarks on the general code quality in #303