Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Example files for each sub-reader #45

Merged
merged 17 commits into from
May 13, 2024

Conversation

lukaspie
Copy link
Collaborator

@lukaspie lukaspie commented May 3, 2024

  • summarize SPECS readers into one folder
  • update missing examples for all readers
  • update docs to reflect new structure
  • small modifications to SPECS XY reader

@lukaspie lukaspie linked an issue May 3, 2024 that may be closed by this pull request
11 tasks
Copy link
Contributor

github-actions bot commented May 3, 2024

Pull Request Test Coverage Report for Build 8939686183

Details

  • 2 of 2 (100.0%) changed or added relevant lines in 1 file are covered.
  • 160 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.2%) to 67.226%

Files with Coverage Reduction New Missed Lines %
pynxtools_xps/file_parser.py 6 83.05%
pynxtools_xps/xy/xy_specs.py 154 12.89%
Totals Coverage Status
Change from base Build 8937112469: -0.2%
Covered Lines: 2283
Relevant Lines: 3396

💛 - Coveralls

@coveralls
Copy link

coveralls commented May 3, 2024

Pull Request Test Coverage Report for Build 9061793761

Details

  • 26 of 53 (49.06%) changed or added relevant lines in 5 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.1%) to 67.098%

Changes Missing Coverage Covered Lines Changed/Added Lines %
pynxtools_xps/specs/xy/xy_specs.py 19 46 41.3%
Totals Coverage Status
Change from base Build 9060665920: -0.1%
Covered Lines: 2282
Relevant Lines: 3401

💛 - Coveralls

@lukaspie lukaspie marked this pull request as ready for review May 3, 2024 14:17
@lukaspie lukaspie requested review from domna and RubelMozumder May 3, 2024 14:17
Copy link
Contributor

@RubelMozumder RubelMozumder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks all good to me. I had a small confusion with the app def. if you fix that or reason that, immediately I can approve this PR.

@lukaspie lukaspie merged commit bab867a into main May 13, 2024
6 checks passed
@lukaspie lukaspie deleted the 15-example-files-for-each-sub-reader branch May 13, 2024 11:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Example files for each sub-reader
4 participants