Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove default attributes from fields #23

Merged
merged 2 commits into from
Mar 15, 2024
Merged

Remove default attributes from fields #23

merged 2 commits into from
Mar 15, 2024

Conversation

lukaspie
Copy link
Collaborator

No description provided.

@lukaspie lukaspie linked an issue Mar 13, 2024 that may be closed by this pull request
[Bug]: There should be no default attribute on the NXdata/data field #22
Closed
@coveralls
Copy link

coveralls commented Mar 13, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 8293261023

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 34.003%
Totals Coverage Status
Change from base Build 8051833404: 0.0%
Covered Lines: 846
Relevant Lines: 2488
💛 - Coveralls

@coveralls
Copy link

Pull Request Test Coverage Report for Build 8263096512

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 34.003%
Totals Coverage Status
Change from base Build 8051833404: 0.0%
Covered Lines: 846
Relevant Lines: 2488
💛 - Coveralls

@lukaspie lukaspie requested a review from domna March 13, 2024 10:59
domna
domna reviewed Mar 15, 2024
View reviewed changes
Copy link
Collaborator

@domna domna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure about the change of entry to None. Should this not still be entry?

pynxtools_xps/config/config_sle_specs.json Show resolved Hide resolved
pynxtools_xps/config/config_xml_specs.json Show resolved Hide resolved
pynxtools_xps/config/config_vms.json Show resolved Hide resolved
pynxtools_xps/config/config_specs_xy.json Show resolved Hide resolved
pynxtools_xps/config/config_txt_scienta.json Show resolved Hide resolved
@lukaspie lukaspie merged commit 6603d86 into main Mar 15, 2024
6 checks passed
@lukaspie lukaspie deleted the 22-no-default-attribute-on-nxdata branch March 15, 2024 09:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@domna domna domna approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: There should be no default attribute on the NXdata/data field
3 participants
@lukaspie @coveralls @domna