Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update topnav-social.html #131

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Update topnav-social.html #131

wants to merge 2 commits into from

Conversation

wittigue
Copy link
Collaborator

deleted Twitter/X
added Bluesky

deleted Twitter/X
added Bluesky
@wittigue wittigue requested a review from PhilReedData February 7, 2025 09:41
@PhilReedData
Copy link
Collaborator

Thanks @wittigue. I've checked out this branch and deployed it locally, and it still shows Twitter for me.
image

I've looked at my code, it is definitely showing your changes in _includes/topnav-social.html , but it is generating in _site/index.html code that still shows Twitter.

What happens when you run it locally?

@PhilReedData
Copy link
Collaborator

Also, I raised an issue in ETT GH to see if anyone was adding Bluesky as a 'native' option.
ELIXIR-Belgium/elixir-toolkit-theme#321

I've done it manually on our eScience Lab site, I was thinking about making a PR to the ETT parent theme, when I have time. https://esciencelab.org.uk/about/

@wittigue
Copy link
Collaborator Author

wittigue commented Feb 7, 2025

I don't have a local version and could not test it.
Thanks for checking the ETT.

@PhilReedData
Copy link
Collaborator

I'm making a pull request in ETT for Bluesky now. It only needs three small changes. https://github.com/PhilReedData/elixir-toolkit-theme/releases/tag/bluesky-002
image
image
I will take out the Twitter logo for FAIRDOM. These images are for me to show Bert that my code supports both, with an updated name for those still using Twitter as X (if he wants it).

As soon as these changes are picked up in an ETT release, I'll update FAIRDOM to use that. Can we wait until then?

Will need to change remote theme to the ETT version that supports Bluesky after my PR is accepted.
@PhilReedData
Copy link
Collaborator

To watch: my PR on parent ETT: ELIXIR-Belgium/elixir-toolkit-theme#325

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants