Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve comments for unit-specific blueprint fields #6587

Open
wants to merge 5 commits into
base: develop
Choose a base branch
from

Conversation

lL1l1
Copy link
Contributor

@lL1l1 lL1l1 commented Dec 18, 2024

Description of the proposed changes

  • Improve descriptions for blueprint fields that say "used by" by adding the unit ID or class name
  • Annotate SinkLower ("used by" megalith and monkeylord)
  • Remove Omen's non-functional weapon opening animations

Testing done on the proposed changes

  • Placed a monkeylord on a mountain peak to see what SinkLower does.
  • Imported Omen's weapon animations into blender and noticed that they don't work because there are bones missing from the mesh.

Checklist

  • Changes are annotated, including comments where useful
  • Changes are documented in the changelog for the next game version

mainly just adding the blueprint ID for ease of lookup
the mesh doesn't have the bones needed by the opening animation
for the fields that are "used by" a specific unit
@lL1l1 lL1l1 added area: unit-blueprint related to issues in unit blueprints (*_unit.bp) type: intellisense labels Dec 18, 2024
@lL1l1 lL1l1 marked this pull request as ready for review December 24, 2024 00:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: unit-blueprint related to issues in unit blueprints (*_unit.bp) type: intellisense
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant