-
Notifications
You must be signed in to change notification settings - Fork 236
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Preserve the world camera when switching to/from split view #6576
Conversation
Mhh, some formatting got in too. |
@BlackYps Small but nice change to include in the hotfix perhaps. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The actual changes work and look good. I considered whether or not the right view's camera settings should preserved, but since it's not as persistent as the left view it doesn't need preservation (although an argument could be made for preference of left/right as the "main" view).
The formatting of long statements into multiline fragments is annoying (for me at least), maybe that could be changed in the repository's default vscode settings file, to more officially/consistently make it not happen? Currently some files have that formatting, while others don't. In particular I think the Prettier formatter doesn't like the blueprint file formatter, and conflicts on the format of sound blueprint tables.
I agree, I think it is a small change to let prettier ignore it. I'd need to look into it. |
Prettier doesn't get used for Lua files, the extension's own formatter is, and it has a weird config format: the |
Description of the proposed changes
Preserves the settings of the primary world camera when switching to/from split view.
Testing done on the proposed changes
Start up the game and switch to/from split view.
Additional context
split-screen.mp4
Checklist