Fix bombers missing during vertical movement #6572
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lL1l1
added
type: bug
area: sim
Hdt80bro
reviewed
Dec 3, 2024
| -- The projectile will have velocity in the horizontal plane equal to the unit's 3 dimensional speed | ||
| -- Multiply the XZ components by the ratio of the XYZ to XZ speeds to get the correct XZ components | ||
| local projVelXZSquareSum = projVelX * projVelX + projVelZ * projVelZ | ||
| local multiplier = math.sqrt((projVelXZSquareSum + _ * _) / (projVelXZSquareSum)) |
There was a problem hiding this comment.
Now that the variable is being used, projVelY shouldn't be called _ anymore
There was a problem hiding this comment.
_ gets reused:
Should it be initialized as a local here?
There was a problem hiding this comment.
In the end, it's all for readability - here it's just indicating that a variable that needs to be there isn't used. Ideally, it'd be redefined every time so that the function can more easily pop its return values into sequential registers, but I don't recall if shadowed variables in Lua get their register slot freed.
|
@BlackYps this may also be nice to include. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Bombers miss when moving vertically because bombs inherit launcher XYZ momentum rotated onto the XZ plane, but the Lua calculation assumes only launcher XZ momentum is inherited.
Description of the proposed changes
Add a few lines fixing the XZ momentum used by the Lua calcuation.
Testing done on the proposed changes
Order a bomber to attack somewhere where it will be changing altitude, it should be perfectly accurate now. The easiest way is to groundfire in front of a landed bomber. You can also groundfire the peak of a mountain.
Left: no fix. Right: fixed
Fixed.bomber.accuracy.mp4
Additional context
The engine still calculates the bomb drop zone independently for firing the bomb, and may not let the bomb fire at all. You can use
ai_RenderBombDropZoneto see the drop zone.Bombs still have a speed limit in the projectile bp in an effort to reduce the minimum bomb drop time in the case of bombing right under the bomber, but this can make them miss when they fire downwards from a high altitude, where the bomb will accelerate a lot.
Checklist